From 03465c3c1484ece34f0200a5ea9a883365e12f2a Mon Sep 17 00:00:00 2001 From: Mahesh Patil Date: Fri, 15 Nov 2019 16:51:38 -0800 Subject: [PATCH] nvethernet: use safe version of sprintf Issue: possible buffer overrun with sprintf() Fix: Use scnprintf() instead of sprintf() Bug 2715372 Change-Id: Ie3564bc41831ed8acf5b40d8a9f5a12e65cdc98a Signed-off-by: Mahesh Patil Reviewed-on: https://git-master.nvidia.com/r/2240400 Reviewed-by: Automatic_Commit_Validation_User Reviewed-by: Bhadram Varka Reviewed-by: Narayan Reddy GVS: Gerrit_Virtual_Submit Reviewed-by: Ashutosh Jha Reviewed-by: mobile promotions Tested-by: mobile promotions --- drivers/net/ethernet/nvidia/nvethernet/sysfs.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/nvidia/nvethernet/sysfs.c b/drivers/net/ethernet/nvidia/nvethernet/sysfs.c index 389c892d..4593de6f 100644 --- a/drivers/net/ethernet/nvidia/nvethernet/sysfs.c +++ b/drivers/net/ethernet/nvidia/nvethernet/sysfs.c @@ -33,8 +33,9 @@ static ssize_t ether_mac_loopback_show(struct device *dev, struct net_device *ndev = (struct net_device *)dev_get_drvdata(dev); struct ether_priv_data *pdata = netdev_priv(ndev); - return sprintf(buf, "%s\n", (pdata->mac_loopback_mode == 1) ? - "enabled" : "disabled"); + return scnprintf(buf, PAGE_SIZE, "%s\n", + (pdata->mac_loopback_mode == 1U) ? + "enabled" : "disabled"); } /**