From 19de6baf19149efa8db64944bf27a80d5598cc0f Mon Sep 17 00:00:00 2001 From: Jinesh Parakh Date: Thu, 2 Jun 2022 12:05:53 +0530 Subject: [PATCH] drivers: devfreq: Fix CERT-C Violations Fix the following CERT-C Violations: governor_pod_scaling_v2.c : CERT ERR33-C The violations occur due to non-verification of the snprintf return values. Adding WARN_ON statements to verify the return values. CID 378002 CID 391305 CID 442828 CID 443110 Bug 3512546 Signed-off-by: Jinesh Parakh Change-Id: I91c35ecce9348d4f7127eafa603d2b8c2391ba18 Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvidia/+/2723684 Tested-by: mobile promotions Reviewed-by: mobile promotions --- drivers/devfreq/governor_pod_scaling_v2.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/devfreq/governor_pod_scaling_v2.c b/drivers/devfreq/governor_pod_scaling_v2.c index 31adc484..6bd1d367 100644 --- a/drivers/devfreq/governor_pod_scaling_v2.c +++ b/drivers/devfreq/governor_pod_scaling_v2.c @@ -445,9 +445,11 @@ static void nvhost_scale_emc_debug_init(struct devfreq *df) { struct podgov_info_rec *podgov = df->data; char dirname[128]; + int err; - snprintf(dirname, sizeof(dirname), "%s_scaling", + err = snprintf(dirname, sizeof(dirname), "%s_scaling", to_platform_device(df->dev.parent)->name); + WARN_ON(err < 0); if (!podgov) return; @@ -506,6 +508,7 @@ static ssize_t enable_3d_scaling_show(struct kobject *kobj, ssize_t res; res = snprintf(buf, PAGE_SIZE, "%d\n", podgov->enable); + WARN_ON(res < 0); return res; } @@ -542,6 +545,7 @@ static ssize_t user_show(struct kobject *kobj, ssize_t res; res = snprintf(buf, PAGE_SIZE, "%d\n", podgov->p_user); + WARN_ON(res < 0); return res; } @@ -571,6 +575,7 @@ static ssize_t freq_request_show(struct kobject *kobj, ssize_t res; res = snprintf(buf, PAGE_SIZE, "%d\n", podgov->p_freq_request); + WARN_ON(res < 0); return res; }