From 2a68302c1209dd1b9aa8c9b82dadb7a30995a2fe Mon Sep 17 00:00:00 2001 From: Mohan Thadikamalla Date: Thu, 26 Aug 2021 15:37:04 +0530 Subject: [PATCH] nvethernet: Fix crash on VLAN filter update MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Issue: Observed crash during the VLAN filter when the interface is down. Fix: Don’t update the VLAN filter if the interface is not running. Bug 200765532 Change-Id: I3dc87fd856b2389aabc9552685103c5bc60fdacf Signed-off-by: Mohan Thadikamalla Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvidia/+/2583630 Tested-by: mobile promotions Reviewed-by: mobile promotions --- drivers/net/ethernet/nvidia/nvethernet/ether_linux.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/nvidia/nvethernet/ether_linux.c b/drivers/net/ethernet/nvidia/nvethernet/ether_linux.c index 8b1d9d9f..cc479fed 100644 --- a/drivers/net/ethernet/nvidia/nvethernet/ether_linux.c +++ b/drivers/net/ethernet/nvidia/nvethernet/ether_linux.c @@ -3760,6 +3760,10 @@ static int ether_vlan_rx_add_vid(struct net_device *ndev, __be16 vlan_proto, struct osi_ioctl ioctl_data = {}; int ret = -1; + if (!netif_running(ndev)) { + return 0; + } + if (pdata->vlan_hash_filtering == OSI_HASH_FILTER_MODE) { dev_err(pdata->dev, "HASH FILTERING for VLAN tag is not supported in SW\n");