mirror of
git://nv-tegra.nvidia.com/linux-nv-oot.git
synced 2025-12-24 10:11:26 +03:00
DCE-KMD: Refactor dce-os-worker.c/.h
- dce-os-worker.c/.h module exposes functionality which allows
DCE KMD clients to wait/signal events.
- The current abstraction of this module has following drawbacks
which this change attempts to address:
* Name: dce-os-worker is a misnomer
- Rename to dce-wait-cond.c/.h and make it a dce-kmd core file.
- Rename functions accordingly.
* dce-os-worker module initializes data structures from tegra_dce
which makes it ineligible for re-use.
- dce-client-ipc can re-use this module as it uses exact
same functionality.
- But this module is tied with DCE-KMD core such that it has
functions that operate on fixed known inputs.
- dce_os_work_cond_sw_resource_init/deinit()
Inits/Deinits most but not all condition var resources
from tegra_dce. Eg. dce-client-ipc resources
are not initialized.
- Move this function to new core file:dce-waiters.c
- All other functions require msg_id as input and can only
operate on DCE_WAIT* resources making it ineligible
to be used by other clients like dce-client-ipc.
- Refactor these fucntions to operate on
individual wait conditions so that all DCE-KMD
core modules can reuse them.
- Additionally, this change will also remove unused functions
and macros from dce-os-cond.c/.h
- dce-client-ipc will also switch to use dce-wait-cond interface
for client ipc waits.
- Make dce-os-cond.h a common file and move OS specific impl
to dce-os-cond-internal.h
JIRA TDS-16581
Change-Id: Ie8c6ec724e48cde66917fab4aa43e7da464ef8fb
Signed-off-by: anupamg <anupamg@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nv-oot/+/3258562
Reviewed-by: Vinod Gopalakrishnakurup <vinodg@nvidia.com>
Reviewed-by: Arun Swain <arswain@nvidia.com>
This commit is contained in:
@@ -272,13 +272,6 @@ void dce_os_log_msg(struct tegra_dce *d, const char *func_name, int line,
|
||||
dce_print(func_name, line, type, log);
|
||||
}
|
||||
|
||||
/**
|
||||
* dce_os_cond_init - Initialize a condition variable
|
||||
*
|
||||
* @cond - The condition variable to initialize
|
||||
*
|
||||
* Initialize a condition variable before using it.
|
||||
*/
|
||||
int dce_os_cond_init(struct dce_os_cond *cond)
|
||||
{
|
||||
init_waitqueue_head(&cond->wq);
|
||||
@@ -287,43 +280,11 @@ int dce_os_cond_init(struct dce_os_cond *cond)
|
||||
return 0;
|
||||
}
|
||||
|
||||
/**
|
||||
* dce_os_cond_destroy - Destroy a condition variable
|
||||
*
|
||||
* @cond - The condition variable to destroy
|
||||
*/
|
||||
void dce_os_cond_destroy(struct dce_os_cond *cond)
|
||||
{
|
||||
cond->initialized = false;
|
||||
}
|
||||
|
||||
/**
|
||||
* dce_os_cond_signal - Signal a condition variable
|
||||
*
|
||||
* @cond - The condition variable to signal
|
||||
*
|
||||
* Wake up a waiter for a condition variable to check if its condition has been
|
||||
* satisfied.
|
||||
*
|
||||
* The waiter is using an uninterruptible wait.
|
||||
*/
|
||||
void dce_os_cond_signal(struct dce_os_cond *cond)
|
||||
{
|
||||
WARN_ON(!cond->initialized);
|
||||
|
||||
wake_up(&cond->wq);
|
||||
}
|
||||
|
||||
/**
|
||||
* dce_os_cond_signal_interruptible - Signal a condition variable
|
||||
*
|
||||
* @cond - The condition variable to signal
|
||||
*
|
||||
* Wake up a waiter for a condition variable to check if its condition has been
|
||||
* satisfied.
|
||||
*
|
||||
* The waiter is using an interruptible wait.
|
||||
*/
|
||||
void dce_os_cond_signal_interruptible(struct dce_os_cond *cond)
|
||||
{
|
||||
WARN_ON(!cond->initialized);
|
||||
@@ -331,37 +292,6 @@ void dce_os_cond_signal_interruptible(struct dce_os_cond *cond)
|
||||
wake_up_interruptible(&cond->wq);
|
||||
}
|
||||
|
||||
/**
|
||||
* dce_os_cond_broadcast - Signal all waiters of a condition variable
|
||||
*
|
||||
* @cond - The condition variable to signal
|
||||
*
|
||||
* Wake up all waiters for a condition variable to check if their conditions
|
||||
* have been satisfied.
|
||||
*
|
||||
* The waiters are using an uninterruptible wait.
|
||||
*/
|
||||
int dce_os_cond_broadcast(struct dce_os_cond *cond)
|
||||
{
|
||||
if (!cond->initialized)
|
||||
return -EINVAL;
|
||||
|
||||
wake_up_all(&cond->wq);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
/**
|
||||
* dce_os_cond_broadcast_interruptible - Signal all waiters of a condition
|
||||
* variable
|
||||
*
|
||||
* @cond - The condition variable to signal
|
||||
*
|
||||
* Wake up all waiters for a condition variable to check if their conditions
|
||||
* have been satisfied.
|
||||
*
|
||||
* The waiters are using an interruptible wait.
|
||||
*/
|
||||
int dce_os_cond_broadcast_interruptible(struct dce_os_cond *cond)
|
||||
{
|
||||
if (!cond->initialized)
|
||||
|
||||
Reference in New Issue
Block a user