nv-tegra-mirror/linux-nv-oot
1
0
Fork 0
mirror of git://nv-tegra.nvidia.com/linux-nv-oot.git synced 2025-12-24 02:01:36 +03:00
Code Issues Packages Projects Releases Wiki Activity

DCE-KMD: Refactor dce-os-worker.c/.h

Browse Source 
- dce-os-worker.c/.h module exposes functionality which allows
  DCE KMD clients to wait/signal events.

- The current abstraction of this module has following drawbacks
  which this change attempts to address:
    * Name: dce-os-worker is a misnomer
        - Rename to dce-wait-cond.c/.h and make it a dce-kmd core file.
        - Rename functions accordingly.
    * dce-os-worker module initializes data structures from tegra_dce
      which makes it ineligible for re-use.
        - dce-client-ipc can re-use this module as it uses exact
          same functionality.
        - But this module is tied with DCE-KMD core such that it has
          functions that operate on fixed known inputs.
            - dce_os_work_cond_sw_resource_init/deinit()
                Inits/Deinits most but not all condition var resources
                from tegra_dce. Eg. dce-client-ipc resources
                are not initialized.
                    - Move this function to new core file:dce-waiters.c
            - All other functions require msg_id as input and can only
              operate on DCE_WAIT* resources making it ineligible
              to be used by other clients like dce-client-ipc.
                    - Refactor these fucntions to operate on
                      individual wait conditions so that all DCE-KMD
                      core modules can reuse them.

- Additionally, this change will also remove unused functions
  and macros from dce-os-cond.c/.h

- dce-client-ipc will also switch to use dce-wait-cond interface
  for client ipc waits.

- Make dce-os-cond.h a common file and move OS specific impl
  to dce-os-cond-internal.h

JIRA TDS-16581

Change-Id: Ie8c6ec724e48cde66917fab4aa43e7da464ef8fb
Signed-off-by: anupamg <anupamg@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nv-oot/+/3258562
Reviewed-by: Vinod Gopalakrishnakurup <vinodg@nvidia.com>
Reviewed-by: Arun Swain <arswain@nvidia.com>
This commit is contained in:
anupamg
2024-11-27 23:43:00 +00:00
committed by Jon Hunter
parent 3e2343fa57
commit 2bed40f6fe
17 changed files with 422 additions and 427 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/platform/tegra/dce/include/dce-client-ipc-internal.h
View File

@@ -22,8 +22,7 @@
* @int_type : IPC interface type for above IPC type as defined in CPU driver
* @d : pointer to OS agnostic dce struct. Stores all runtime info for dce
* cluster elements
* @recv_wait : condition variable used for IPC synchronization
* @complete : atomic variable used for IPC synchronization
* @recv_wait : wait condition variable used for IPC synchronization
* @callback_fn : function pointer to the callback function passed by the
* client during registration
*/
@@ -34,8 +33,7 @@ struct tegra_dce_client_ipc {
uint32_t handle;
uint32_t int_type;
struct tegra_dce *d;
struct dce_os_cond recv_wait;
dce_os_atomic_t complete;
struct dce_wait_cond recv_wait;
tegra_dce_client_ipc_callback_t callback_fn;
};