From 46f980b8064bf5163bfbb64e53ee623c4b9076ba Mon Sep 17 00:00:00 2001 From: Vamsee Vardhan Thummala Date: Wed, 23 Aug 2023 11:23:07 +0000 Subject: [PATCH] drm/tegra: firewall: Check for is_addr_reg existence in IMM check In the IMM opcode check, don't call is_addr_reg if it's not set. Fixes: 8cc95f3fd35e ("drm/tegra: Add job firewall") Change-Id: I2b7b35afeed774a571fd147aa922718f644c5c88 Signed-off-by: Mikko Perttunen Signed-off-by: Thierry Reding Signed-off-by: Vamsee Vardhan Thummala Reviewed-on: https://git-master.nvidia.com/r/c/linux-nv-oot/+/2966639 GVS: Gerrit_Virtual_Submit --- drivers/gpu/drm/tegra/firewall.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/tegra/firewall.c b/drivers/gpu/drm/tegra/firewall.c index 1824d2db..d53f890f 100644 --- a/drivers/gpu/drm/tegra/firewall.c +++ b/drivers/gpu/drm/tegra/firewall.c @@ -97,6 +97,9 @@ static int fw_check_regs_imm(struct tegra_drm_firewall *fw, u32 offset) { bool is_addr; + if (!fw->client->ops->is_addr_reg) + return 0; + is_addr = fw->client->ops->is_addr_reg(fw->client->base.dev, fw->class, offset); if (is_addr)