From 5d872b9a0d200a9ba1512a006d78b83f5730e07f Mon Sep 17 00:00:00 2001 From: Manish Bhardwaj Date: Mon, 10 Jul 2023 16:19:08 +0530 Subject: [PATCH] storage: fix cert-c issue in storage driver Using this patch we are fixing below cert error:- 1. var_deref_model: Passing null pointer bio_req to req_op, which dereferences it. CID 10177627 Bug 3512545 Signed-off-by: Manish Bhardwaj Change-Id: Id9c71a82d3adf52590816fa87b53a8965da5c105 Reviewed-on: https://git-master.nvidia.com/r/c/linux-nv-oot/+/2933682 Reviewed-by: svcacv Reviewed-by: Sachin Nikam GVS: Gerrit_Virtual_Submit --- drivers/block/tegra_virt_storage/tegra_hv_vblk.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/block/tegra_virt_storage/tegra_hv_vblk.c b/drivers/block/tegra_virt_storage/tegra_hv_vblk.c index 1d121733..e6aa3633 100644 --- a/drivers/block/tegra_virt_storage/tegra_hv_vblk.c +++ b/drivers/block/tegra_virt_storage/tegra_hv_vblk.c @@ -437,6 +437,7 @@ static bool complete_bio_req(struct vblk_dev *vblkdev) dev_err(vblkdev->device, "VSC request %d has null bio request!\n", vsc_req->id); + goto bio_null; } if ((!vblkdev->config.blk_config.use_vm_address && READ_WRITE_OR_IOCTL_OP) @@ -448,6 +449,7 @@ static bool complete_bio_req(struct vblk_dev *vblkdev) vblkdev->mempool_free = vblkdev->mempool_free + vsc_req->__data_len; } +bio_null: vblk_put_req(vsc_req); complete_bio_exit: