nv-tegra-mirror/linux-nv-oot
1
0
Fork 0
mirror of git://nv-tegra.nvidia.com/linux-nv-oot.git synced 2025-12-22 17:25:35 +03:00
Code Issues Packages Projects Releases Wiki Activity

tsec: fix coverity defect

Browse Source 
Issue:
Unchecked return value for clk_prepare_enable function.

Fix:
Add check for return value of clk_prepare_enable function and take
proper action in case of error.

CID 10162292

Bug 3952896

Change-Id: I2f3a75d028fbed2f855b72d2efc9a30844b8c336
Signed-off-by: Sahil Mukund Patki <spatki@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nv-oot/+/2950809
Reviewed-by: Ketan Patil <ketanp@nvidia.com>
Reviewed-by: svcacv <svcacv@nvidia.com>
Reviewed-by: Bharat Nihalani <bnihalani@nvidia.com>
GVS: Gerrit_Virtual_Submit <buildbot_gerritrpt@nvidia.com>
This commit is contained in:
Sahil Mukund Patki
2023-08-07 05:27:24 +00:00
committed by mobile promotions
parent c983eec625
commit 61af983ca4
1 changed files with 15 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
drivers/video/tegra/tsec/tsec.c
View File

@@ -337,7 +337,10 @@ static int tsec_module_init(struct platform_device *dev)
clk_set_rate(pdata->clk[TSEC_CLK_INDEX],
clk_round_rate(pdata->clk[TSEC_CLK_INDEX],
pdata->rate[TSEC_CLK_INDEX]));
clk_prepare_enable(pdata->clk[TSEC_CLK_INDEX]);
if (clk_prepare_enable(pdata->clk[TSEC_CLK_INDEX]) != 0) {
dev_err(&dev->dev, "failed to enable %s clk", TSEC_CLK_NAME);
return -ENXIO;
}
/* get EFUSE_CLK and enable it */
pdata->clk[EFUSE_CLK_INDEX] = devm_clk_get(&dev->dev, EFUSE_CLK_NAME);
@@ -349,7 +352,11 @@ static int tsec_module_init(struct platform_device *dev)
clk_set_rate(pdata->clk[EFUSE_CLK_INDEX],
clk_round_rate(pdata->clk[EFUSE_CLK_INDEX],
pdata->rate[EFUSE_CLK_INDEX]));
clk_prepare_enable(pdata->clk[EFUSE_CLK_INDEX]);
if (clk_prepare_enable(pdata->clk[EFUSE_CLK_INDEX]) != 0) {
dev_err(&dev->dev, "failed to enable %s clk", EFUSE_CLK_NAME);
clk_disable_unprepare(pdata->clk[TSEC_CLK_INDEX]);
return -ENXIO;
}
/* get TSEC_PKA_CLK and enable it */
pdata->clk[TSEC_PKA_CLK_INDEX] = devm_clk_get(&dev->dev, TSEC_PKA_CLK_NAME);
@@ -362,7 +369,12 @@ static int tsec_module_init(struct platform_device *dev)
clk_set_rate(pdata->clk[TSEC_PKA_CLK_INDEX],
clk_round_rate(pdata->clk[TSEC_PKA_CLK_INDEX],
pdata->rate[TSEC_PKA_CLK_INDEX]));
clk_prepare_enable(pdata->clk[TSEC_PKA_CLK_INDEX]);
if (clk_prepare_enable(pdata->clk[TSEC_PKA_CLK_INDEX]) != 0) {
dev_err(&dev->dev, "failed to enable %s clk", TSEC_PKA_CLK_NAME);
clk_disable_unprepare(pdata->clk[EFUSE_CLK_INDEX]);
clk_disable_unprepare(pdata->clk[TSEC_CLK_INDEX]);
return -ENXIO;
}
/* get reset_control and reset the module */
pdata->reset_control = devm_reset_control_get_exclusive_released(