From 6883238a210cefea4c4c0086f5d3c9c6a7ab3032 Mon Sep 17 00:00:00 2001 From: Mahesh Patil Date: Mon, 7 Aug 2023 23:00:18 -0700 Subject: [PATCH] nvethernet: Fix coverity "unused value" Bug 3952896 Change-Id: Ie30c3da4d0979f664cb3c951794e905b52e5c005 Signed-off-by: Mahesh Patil Reviewed-on: https://git-master.nvidia.com/r/c/linux-nv-oot/+/2952208 Reviewed-by: Nagaraj Annaiah Reviewed-by: Bhadram Varka Reviewed-by: Ashutosh Jha --- drivers/net/ethernet/nvidia/nvethernet/ether_linux.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/nvidia/nvethernet/ether_linux.c b/drivers/net/ethernet/nvidia/nvethernet/ether_linux.c index b3ff1ca1..6da5666f 100644 --- a/drivers/net/ethernet/nvidia/nvethernet/ether_linux.c +++ b/drivers/net/ethernet/nvidia/nvethernet/ether_linux.c @@ -6086,13 +6086,12 @@ static int ether_parse_dt(struct ether_priv_data *pdata) } /* Read pad calibration config reg offset, default 0 */ - ret = of_property_read_u32(np, "nvidia,pad_auto_cal_pu_offset", + ret_val = of_property_read_u32(np, "nvidia,pad_auto_cal_pu_offset", &dt_pad_auto_cal_pu_offset); - if (ret < 0) { + if (ret_val < 0) { dev_info(dev, "missing nvidia,pad_auto_cal_pu_offset, " "setting default 0\n"); osi_core->padctrl.pad_auto_cal_pu_offset = 0U; - ret = 0; } else if (dt_pad_auto_cal_pu_offset > OSI_PAD_CAL_CONFIG_PD_PU_OFFSET_MAX) { dev_err(dev, "Error: Invalid dt " @@ -6104,13 +6103,12 @@ static int ether_parse_dt(struct ether_priv_data *pdata) osi_core->padctrl.pad_auto_cal_pu_offset = dt_pad_auto_cal_pu_offset; } - ret = of_property_read_u32(np, "nvidia,pad_auto_cal_pd_offset", + ret_val = of_property_read_u32(np, "nvidia,pad_auto_cal_pd_offset", &dt_pad_auto_cal_pd_offset); - if (ret < 0) { + if (ret_val < 0) { dev_info(dev, "missing nvidia,pad_auto_cal_pd_offset, " "setting default 0\n"); osi_core->padctrl.pad_auto_cal_pd_offset = 0U; - ret = 0; } else if (dt_pad_auto_cal_pd_offset > OSI_PAD_CAL_CONFIG_PD_PU_OFFSET_MAX) { dev_err(dev, "Error: Invalid dt "