From 6b5d0b8383e92f9149a3918a30b8824d0bd839ec Mon Sep 17 00:00:00 2001 From: Vamsee Vardhan Thummala Date: Thu, 10 Apr 2025 05:33:59 +0000 Subject: [PATCH] gpu: host1x: Remove PM ops from DLA host1x bus-side driver Remove power management ops from the host1x bus-side DLA driver. The host1x bus-side driver is a virtual device and should not directly access hardware. PM ops should only be used in the platform device driver. This fixes suspend/resume test failure when tegra-drm is loaded without any enabled engines under host1x node. Bug 5055946 Change-Id: I2e07f759e1d92b4c5a92739e1b5439d39800773f Signed-off-by: Vamsee Vardhan Thummala Reviewed-on: https://git-master.nvidia.com/r/c/linux-nv-oot/+/3337661 Reviewed-by: Sourab Gupta Reviewed-by: Mikko Perttunen Reviewed-by: Mainak Sen GVS: buildbot_gerritrpt --- .../tegra/host/nvdla/port/device/nvdla_device_host1x.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/video/tegra/host/nvdla/port/device/nvdla_device_host1x.c b/drivers/video/tegra/host/nvdla/port/device/nvdla_device_host1x.c index ea7d4545..d094f996 100644 --- a/drivers/video/tegra/host/nvdla/port/device/nvdla_device_host1x.c +++ b/drivers/video/tegra/host/nvdla/port/device/nvdla_device_host1x.c @@ -396,14 +396,6 @@ static int nvdla_resume(struct device *dev) return nvdla_runtime_resume(dev); } -/* Create our own PM operations structure */ -static const struct dev_pm_ops nvdla_pm_ops = { - .runtime_suspend = nvdla_runtime_suspend, - .runtime_resume = nvdla_runtime_resume, - .suspend = nvdla_suspend, - .resume = nvdla_resume, -}; - /* Module runtime suspend implementation */ int nvdla_module_runtime_suspend(struct device *dev) { @@ -547,7 +539,6 @@ void nvdla_module_complete_resume(struct device *dev) static struct host1x_driver host1x_nvdla_driver = { .driver = { .name = "host1x-nvdla", - .pm = &nvdla_pm_ops, }, };