nv-tegra-mirror/linux-nv-oot
1
0
Fork 0
mirror of git://nv-tegra.nvidia.com/linux-nv-oot.git synced 2025-12-22 17:25:35 +03:00
Code Issues Packages Projects Releases Wiki Activity

media:i2c: fix ar1335 control command

Browse Source 
When ar1335_common.c was ported to K5.15 it was refactored
based on the review comments. During that process index
in mcu_send_ctrl_cmd() was set to 0xFFFF which was causing
issue in setting sensor format. Pass the index from the
caller of mcu_send_ctrl_cmd().

Bug 4389285

Change-Id: Ic84a8de58051fe947f0f4d6597d1a55bc29ef9e6
Signed-off-by: Ankur Pawar <ankurp@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nv-oot/+/3024535
Reviewed-by: Praveen AC <pac@nvidia.com>
Reviewed-by: Laxman Dewangan <ldewangan@nvidia.com>
GVS: Gerrit_Virtual_Submit <buildbot_gerritrpt@nvidia.com>
This commit is contained in:
Ankur Pawar
2023-01-25 05:38:51 +00:00
committed by mobile promotions
parent f877c7e3da
commit 7096cb09a5
1 changed files with 14 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
drivers/media/i2c/ar1335_common.c
View File

@@ -1,8 +1,8 @@
// SPDX-License-Identifier: GPL-2.0-only // SPDX-License-Identifier: GPL-2.0-only
// Copyright (c) 2017-2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. // SPDX-FileCopyrightText: Copyright (c) 2017-2024, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
// Copyright (c) 2022, e-con Systems. All rights reserved. // Copyright (c) 2022, e-con Systems. All rights reserved.
/* /*
* ar1335.c - AR1335 sensor driver * ar1335_common.c - AR1335 sensor driver
*/ */
#include <nvidia/conftest.h> #include <nvidia/conftest.h>
@@ -52,11 +52,13 @@ static uint32_t u8arr_to_uint32(uint8_t *in_arr)
in_arr[3]); in_arr[3]);
} }
static int mcu_send_ctrl_cmd(struct i2c_client *client, int cmd, uint32_t payload_len) static int mcu_send_ctrl_cmd(struct i2c_client *client,
int cmd,
uint32_t payload_len,
uint16_t index)
{ {
int err; int err;
uint8_t orig_crc = 0, calc_crc = 0; uint8_t orig_crc = 0, calc_crc = 0;
uint16_t index = 0xFFFF;
mc_data[0] = CMD_SIGNATURE; mc_data[0] = CMD_SIGNATURE;
mc_data[1] = cmd; mc_data[1] = cmd;
@@ -986,7 +988,7 @@ static int mcu_get_ctrl(struct i2c_client *client, uint32_t arg_ctrl_id,
/* First Txn Payload length = 2 */ /* First Txn Payload length = 2 */
payload_len = 2; payload_len = 2;
ret = mcu_send_ctrl_cmd(client, CMD_ID_GET_CTRL, payload_len); ret = mcu_send_ctrl_cmd(client, CMD_ID_GET_CTRL, payload_len, index);
if (ret) { if (ret) {
dev_err(&client->dev, "CMD_ID_GET_CTRL send failed\n"); dev_err(&client->dev, "CMD_ID_GET_CTRL send failed\n");
goto exit; goto exit;
@@ -1152,7 +1154,8 @@ static int mcu_list_fmts(struct i2c_client *client,ISP_STREAM_INFO *stream_info,
/* First Txn Payload length = 0 */ /* First Txn Payload length = 0 */
payload_len = 2; payload_len = 2;
ret = mcu_send_ctrl_cmd(client, CMD_ID_GET_STREAM_INFO, payload_len); ret = mcu_send_ctrl_cmd(client, CMD_ID_GET_STREAM_INFO,
payload_len, index);
if (ret) { if (ret) {
dev_err(&client->dev, "CMD_ID_GET_STREAM_INFO send failed\n"); dev_err(&client->dev, "CMD_ID_GET_STREAM_INFO send failed\n");
goto exit; goto exit;
@@ -1274,7 +1277,8 @@ static int mcu_get_ctrl_ui(struct i2c_client *client,
/* First Txn Payload length = 0 */ /* First Txn Payload length = 0 */
payload_len = 2; payload_len = 2;
ret = mcu_send_ctrl_cmd(client, CMD_ID_GET_CTRL_UI_INFO, payload_len); ret = mcu_send_ctrl_cmd(client, CMD_ID_GET_CTRL_UI_INFO,
payload_len, index);
if (ret) { if (ret) {
dev_err(&client->dev, "CMD_ID_GET_CTRL_UI_INFO send failed\n"); dev_err(&client->dev, "CMD_ID_GET_CTRL_UI_INFO send failed\n");
goto exit; goto exit;
@@ -1404,7 +1408,8 @@ static int mcu_list_ctrls(struct i2c_client *client,
/* First Txn Payload length = 0 */ /* First Txn Payload length = 0 */
payload_len = 2; payload_len = 2;
ret = mcu_send_ctrl_cmd(client, CMD_ID_GET_CTRL_INFO, payload_len); ret = mcu_send_ctrl_cmd(client, CMD_ID_GET_CTRL_INFO,
payload_len, index);
if (ret) { if (ret) {
dev_err(&client->dev, "CMD_ID_GET_CTRL_INFO send failed\n"); dev_err(&client->dev, "CMD_ID_GET_CTRL_INFO send failed\n");
goto exit; goto exit;