From 74b186dc9e47f9ac84b2ae527c28e3544ab59089 Mon Sep 17 00:00:00 2001 From: Jon Hunter Date: Tue, 11 Jul 2023 13:52:43 +0100 Subject: [PATCH] drivers: pva: Fix compilation error MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When building the PVA driver with GCC 13 the following error is observed ... drivers/video/tegra/host/pva/pva.c:1366:13: error: the comparison will always evaluate as ‘true’ for the address of ‘clk_cap_kobj’ will never be NULL [-Werror=address] 1366 | if (&pdata->clk_cap_kobj) { | ^ The 'clk_cap_kobj' member of 'nvhost_device_data' structure is not a pointer to a structure but a structure and so the address of the structure is always true. Fix this by testing if the address of the 'clk_cap_attrs' member which is a pointer to memory that is allocated. Bug 4190030 Signed-off-by: Jon Hunter Change-Id: Iafe0da2a59f55420aa96ebc985c5352dfbed9c74 Reviewed-on: https://git-master.nvidia.com/r/c/linux-nv-oot/+/2934461 Reviewed-by: Omar Nemri GVS: Gerrit_Virtual_Submit --- drivers/video/tegra/host/pva/pva.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/tegra/host/pva/pva.c b/drivers/video/tegra/host/pva/pva.c index bb9743e1..27eb7023 100644 --- a/drivers/video/tegra/host/pva/pva.c +++ b/drivers/video/tegra/host/pva/pva.c @@ -1363,7 +1363,7 @@ static int __exit pva_remove(struct platform_device *pdev) #if !IS_ENABLED(CONFIG_TEGRA_GRHOST) struct kobj_attribute *attr = NULL; - if (&pdata->clk_cap_kobj) { + if (pdata->clk_cap_attrs) { for (i = 0; i < pdata->num_clks; i++) { attr = &pdata->clk_cap_attrs[i]; sysfs_remove_file(&pdata->clk_cap_kobj, &attr->attr);