From 7bbf31a2a75b437c1bf4a239d2fdbc6cf6cd8308 Mon Sep 17 00:00:00 2001 From: Rakesh Goyal Date: Tue, 24 Sep 2019 09:00:23 +0530 Subject: [PATCH] nvethernet: fix ndo_vlan_rx_kill_vid() Issue: VLAN tag MAC register access after ether_close() Fix: If netif is not running, return 0 from ndo_vlan_rx_kill_vid and don't call OSI interface call. Bug 200544722 Bug 200545674 Change-Id: Iecb4cb53e0e5cd3a544110b323b5e1c7b04ba1d5 Signed-off-by: Rakesh Goyal Reviewed-on: https://git-master.nvidia.com/r/2204247 Reviewed-by: mobile promotions Tested-by: mobile promotions --- drivers/net/ethernet/nvidia/nvethernet/ether_linux.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/nvidia/nvethernet/ether_linux.c b/drivers/net/ethernet/nvidia/nvethernet/ether_linux.c index f89e3f36..c58368ca 100644 --- a/drivers/net/ethernet/nvidia/nvethernet/ether_linux.c +++ b/drivers/net/ethernet/nvidia/nvethernet/ether_linux.c @@ -2178,6 +2178,10 @@ static int ether_vlan_rx_kill_vid(struct net_device *ndev, __be16 vlan_proto, struct osi_core_priv_data *osi_core = pdata->osi_core; int ret = -1; + if (!netif_running(ndev)) { + return 0; + } + if (pdata->vlan_hash_filtering == OSI_HASH_FILTER_MODE) { dev_err(pdata->dev, "HASH FILTERING for VLAN tag is not supported in SW\n");