nv-tegra-mirror/linux-nv-oot
1
0
Fork 0
mirror of git://nv-tegra.nvidia.com/linux-nv-oot.git synced 2025-12-25 02:32:08 +03:00
Code Issues Packages Projects Releases Wiki Activity

nvadsp: CERT-C Fixes

Browse Source 
Fixed for L1 issues :

Return value check for snprintf
NULL pointer check using IS_ERR_OR_NULL

Bug 3512545

CID 407176
CID 429671
CID 471352

Signed-off-by: Sharad Gupta <sharadg@nvidia.com>
Change-Id: Ib03339db8dc669b6eff448941fac62b2feabf7bc
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvidia/+/2679048
Reviewed-by: svcacv <svcacv@nvidia.com>
Reviewed-by: Akash Kollipara <akollipara@nvidia.com>
Reviewed-by: Sachin Nikam <snikam@nvidia.com>
Reviewed-by: Viswanath L <viswanathl@nvidia.com>
Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com>
Reviewed-by: svc-mobile-cert <svc-mobile-cert@nvidia.com>
Reviewed-by: svc_kernel_abi <svc_kernel_abi@nvidia.com>
GVS: Gerrit_Virtual_Submit
This commit is contained in:
Sharad Gupta
2022-03-09 23:13:51 +05:30
committed by Laxman Dewangan
parent 2204b3fe10
commit 9b526e03db
3 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/platform/tegra/nvadsp/os.c
View File

@@ -332,7 +332,7 @@ bool is_adsp_dram_addr(u64 addr)
int nvadsp_add_load_mappings(phys_addr_t pa, void *mapping, int len)
{
if (map_idx >= NM_LOAD_MAPPINGS)
if (map_idx < 0 || map_idx >= NM_LOAD_MAPPINGS)
return -EINVAL;
adsp_map[map_idx].da = pa;
@@ -884,7 +884,7 @@ static int nvadsp_firmware_load(struct platform_device *pdev)
}
shared_mem = get_mailbox_shared_region(fw);
if (IS_ERR(shared_mem)) {
if (IS_ERR_OR_NULL(shared_mem)) {
if (drv_data->chip_data->adsp_shared_mem_hwmbox != 0) {
/*
* If FW is not explicitly defining a shared memory