nv-tegra-mirror/linux-nv-oot
1
0
Fork 0
mirror of git://nv-tegra.nvidia.com/linux-nv-oot.git synced 2025-12-22 17:25:35 +03:00
Code Issues Packages Projects Releases Wiki Activity

nvethernet: Fix cert c issues

Browse Source 
Issue:
CERT EXP33-C - Using uninitialized value.

Fix:
Initialize variable before use

Bug 3959323

Change-Id: Ia4dc3f58ef13c76305ce8242d38a1863986af193
Signed-off-by: Sushil Singh <sushilkumars@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nv-oot/+/2853914
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
This commit is contained in:
Sushil Singh
2023-02-06 20:23:27 +05:30
committed by mobile promotions
parent 2172c01a6d
commit 9b97e33558
2 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/net/ethernet/nvidia/nvethernet/ether_linux.c
View File

@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-2.0-only // SPDX-License-Identifier: GPL-2.0-only
/* Copyright (c) 2019-2022, NVIDIA CORPORATION & AFFILIATES. All rights reserved */ /* Copyright (c) 2019-2023, NVIDIA CORPORATION. All rights reserved */
#include <linux/version.h> #include <linux/version.h>
#include <linux/iommu.h> #include <linux/iommu.h>
@@ -126,7 +126,7 @@ static irqreturn_t ether_common_isr_thread(int irq, void *data)
struct osi_core_priv_data *osi_core = pdata->osi_core; struct osi_core_priv_data *osi_core = pdata->osi_core;
int ret = 0; int ret = 0;
int i; int i;
struct epl_error_report_frame error_report; struct epl_error_report_frame error_report = {0};
error_report.reporter_id = osi_core->hsi.reporter_id; error_report.reporter_id = osi_core->hsi.reporter_id;
error_report.timestamp = lower_32_bits(rdtsc()); error_report.timestamp = lower_32_bits(rdtsc());
@@ -3745,9 +3745,10 @@ static int ether_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
struct mii_ioctl_data *mii_data; struct mii_ioctl_data *mii_data;
if (!dev || !rq) { if (!dev || !rq) {
dev_err(pdata->dev, "%s: Invalid arg\n", __func__); pr_err("%s: Invalid arg\n", __func__);
return -EINVAL; return -EINVAL;
} }
pdata = netdev_priv(dev); pdata = netdev_priv(dev);
mii_data = if_mii(rq); mii_data = if_mii(rq);
@@ -3829,9 +3830,10 @@ static int ether_siocdevprivate(struct net_device *dev, struct ifreq *rq,
struct mii_ioctl_data *mii_data; struct mii_ioctl_data *mii_data;
if (!dev || !rq) { if (!dev || !rq) {
dev_err(pdata->dev, "%s: Invalid arg\n", __func__); pr_err("%s: Invalid arg\n", __func__);
return -EINVAL; return -EINVAL;
} }
pdata = netdev_priv(dev); pdata = netdev_priv(dev);
mii_data = if_mii(rq); mii_data = if_mii(rq);

4
drivers/net/ethernet/nvidia/nvethernet/macsec.c
View File

@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-2.0-only // SPDX-License-Identifier: GPL-2.0-only
/* Copyright (c) 2019-2022, NVIDIA CORPORATION & AFFILIATES. All rights reserved */ /* Copyright (c) 2019-2023, NVIDIA CORPORATION. All rights reserved */
#ifdef MACSEC_SUPPORT #ifdef MACSEC_SUPPORT
#include "ether_linux.h" #include "ether_linux.h"
@@ -46,7 +46,7 @@ static irqreturn_t macsec_ns_isr_thread(int irq, void *data)
struct osi_core_priv_data *osi_core = pdata->osi_core; struct osi_core_priv_data *osi_core = pdata->osi_core;
int ret = 0; int ret = 0;
int i = 0; int i = 0;
struct epl_error_report_frame error_report; struct epl_error_report_frame error_report = {0};
mutex_lock(&pdata->hsi_lock); mutex_lock(&pdata->hsi_lock);
if (osi_core->hsi.macsec_report_err) { if (osi_core->hsi.macsec_report_err) {