From 9c4438324cca2423ac3239413d8320fcbb27b7fd Mon Sep 17 00:00:00 2001 From: Rakesh Goyal Date: Sun, 25 Aug 2019 09:43:59 +0530 Subject: [PATCH] nvethernet: Fix error in assign default priority Issue: Due to missing "continue" in loop, default priority is overwritten with wrong value. Fix: Add "continue" in if loop to avoid overwriting. Bug 200512422 Change-Id: Ice32f948bba58ea774d37e7508853a5c058b13ad Signed-off-by: Rakesh Goyal Reviewed-on: https://git-master.nvidia.com/r/2183011 Reviewed-by: mobile promotions Tested-by: mobile promotions --- drivers/net/ethernet/nvidia/nvethernet/ether_linux.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/nvidia/nvethernet/ether_linux.c b/drivers/net/ethernet/nvidia/nvethernet/ether_linux.c index 96fc9605..3f3712d7 100644 --- a/drivers/net/ethernet/nvidia/nvethernet/ether_linux.c +++ b/drivers/net/ethernet/nvidia/nvethernet/ether_linux.c @@ -2852,8 +2852,9 @@ static void ether_parse_queue_prio(struct ether_priv_data *pdata, tval[i] = pval[i]; } - /* If Some priority is alreay give to queue or priority in DT more than - * MAX priority, assig default priority to queue with error message + /* If Some priority is already given to queue or priority in DT is + * more than MAX priority, assign default priority to queue with + * error message */ for (i = 0; i < num_entries; i++) { mtlq = osi_core->mtl_queues[i]; @@ -2861,6 +2862,7 @@ static void ether_parse_queue_prio(struct ether_priv_data *pdata, dev_err(pdata->dev, "%s():Wrong or duplicate priority" " in DT entry for Q(%d)\n", __func__, mtlq); pval[mtlq] = val_def; + continue; } pval[mtlq] = tval[i]; pmask |= 1U << tval[i];