nv-tegra-mirror/linux-nv-oot
1
0
Fork 0
mirror of git://nv-tegra.nvidia.com/linux-nv-oot.git synced 2025-12-22 17:25:35 +03:00
Code Issues Packages Projects Releases Wiki Activity

kernel: nvidia-oot: Fix CERT ARR30-C violations

Browse Source 
Fix CERT ARR30-C coverity defects for channel.c

Jira CAMERASW-30796

Change-Id: I1db048087f0996956d95224c0caa6c35ff971eed
Signed-off-by: yangxu <yangxu@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nv-oot/+/3276114
GVS: buildbot_gerritrpt <buildbot_gerritrpt@nvidia.com>
Reviewed-by: Frank Chen <frankc@nvidia.com>
Reviewed-by: Xiaoming Xiang <xxiang@nvidia.com>
Reviewed-by: Ankur Pawar <ankurp@nvidia.com>
Reviewed-by: svcacv <svcacv@nvidia.com>
Reviewed-by: Praveen AC <pac@nvidia.com>
This commit is contained in:
yangxu
2025-01-02 08:30:33 +00:00
committed by Jon Hunter
parent 50c133e18d
commit a268e2a1d2
1 changed files with 15 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
drivers/media/platform/tegra/camera/vi/channel.c
View File

@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-2.0-only // SPDX-License-Identifier: GPL-2.0-only
// SPDX-FileCopyrightText: Copyright (c) 2015-2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved. // SPDX-FileCopyrightText: Copyright (c) 2015-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
/* /*
* NVIDIA Tegra Video Input Device * NVIDIA Tegra Video Input Device
*/ */
@@ -1350,7 +1350,12 @@ int tegra_channel_s_ctrl(struct v4l2_ctrl *ctrl)
/* Prevent changing the bypass mode while the device is still streaming */ /* Prevent changing the bypass mode while the device is still streaming */
if (vb2_is_busy(&chan->queue)) if (vb2_is_busy(&chan->queue))
return -EBUSY; return -EBUSY;
if ((ctrl->val < 0) || (ctrl->val >= ARRAY_SIZE(switch_ctrl_qmenu))) {
dev_err(&chan->video->dev,
"%s: update bypass failed due to an invalid value\n",
__func__);
return -EINVAL;
}
if (switch_ctrl_qmenu[ctrl->val] == SWITCH_ON) if (switch_ctrl_qmenu[ctrl->val] == SWITCH_ON)
chan->bypass = true; chan->bypass = true;
else if (chan->vi->bypass) { else if (chan->vi->bypass) {
@@ -1370,7 +1375,7 @@ int tegra_channel_s_ctrl(struct v4l2_ctrl *ctrl)
if (!s_data) if (!s_data)
break; break;
if (ctrl->val >= ARRAY_SIZE(switch_ctrl_qmenu)) { if ((ctrl->val < 0) || (ctrl->val >= ARRAY_SIZE(switch_ctrl_qmenu))) {
dev_err(&chan->video->dev, dev_err(&chan->video->dev,
"%s: update enable override failed due to an invalid value\n", "%s: update enable override failed due to an invalid value\n",
__func__); __func__);
@@ -1395,7 +1400,7 @@ int tegra_channel_s_ctrl(struct v4l2_ctrl *ctrl)
&chan->fmtinfo->bpp, 0); &chan->fmtinfo->bpp, 0);
break; break;
case TEGRA_CAMERA_CID_VI_SIZE_ALIGN: case TEGRA_CAMERA_CID_VI_SIZE_ALIGN:
if (ctrl->val >= ARRAY_SIZE(size_align_ctrl_qmenu)) { if ((ctrl->val < 0) || (ctrl->val >= ARRAY_SIZE(size_align_ctrl_qmenu))) {
dev_err(&chan->video->dev, dev_err(&chan->video->dev,
"%s: update size alignment failed due to an invalid value\n", "%s: update size alignment failed due to an invalid value\n",
__func__); __func__);
@@ -2432,6 +2437,12 @@ static int tegra_channel_open(struct file *fp)
chan->fh = (struct v4l2_fh *)fp->private_data; chan->fh = (struct v4l2_fh *)fp->private_data;
if (tegra_channel_verify_focuser(chan)) { if (tegra_channel_verify_focuser(chan)) {
if ((chan->num_subdevs <= 0) || (chan->num_subdevs > MAX_SUBDEVICES)) {
dev_err(chan->vi->dev,
"%s: set power failed due to an invalid num_subdevs value\n",
__func__);
return -EINVAL;
}
ret = tegra_channel_set_power(chan, true); ret = tegra_channel_set_power(chan, true);
if (ret < 0) if (ret < 0)
return ret; return ret;