nv-tegra-mirror/linux-nv-oot
1
0
Fork 0
mirror of git://nv-tegra.nvidia.com/linux-nv-oot.git synced 2025-12-22 17:25:35 +03:00
Code Issues Packages Projects Releases Wiki Activity

nvsciipc: remove redundant sysfs node creation

Browse Source 
nvsciipc_uid_groups are redundant since it's already
created by sysfs_create_group.

Bug 5214323

Change-Id: I70f514ff47f30ac1c70b85dec5c0354ef8d85997
Signed-off-by: Joshua Cha <joshuac@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nv-oot/+/3348582
GVS: buildbot_gerritrpt <buildbot_gerritrpt@nvidia.com>
Reviewed-by: Simon Je <sje@nvidia.com>
Reviewed-by: Suneel Kumar Pemmineti <spemmineti@nvidia.com>
Reviewed-by: svcacv <svcacv@nvidia.com>
This commit is contained in:
Joshua Cha
2025-04-24 15:42:33 +09:00
committed by Jon Hunter
parent 737925e58e
commit a81de1a2c6
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/misc/nvsciipc/nvsciipc.c
View File

@@ -984,11 +984,6 @@ static struct attribute_group nvsciipc_uid_group = {
.attrs = nvsciipc_uid_attrs, .attrs = nvsciipc_uid_attrs,
}; };
static const struct attribute_group *nvsciipc_uid_groups[] = {
&nvsciipc_uid_group,
NULL,
};
static const struct file_operations nvsciipc_fops = { static const struct file_operations nvsciipc_fops = {
.owner = THIS_MODULE, .owner = THIS_MODULE,
.open = nvsciipc_dev_open, .open = nvsciipc_dev_open,
@@ -1033,12 +1028,14 @@ static int nvsciipc_probe(struct platform_device *pdev)
goto error; goto error;
} }
dev_info(&pdev->dev, "creating nvsciipc_uid sysfs group\n");
ret = sysfs_create_group(&pdev->dev.kobj, &nvsciipc_uid_group); ret = sysfs_create_group(&pdev->dev.kobj, &nvsciipc_uid_group);
if (ret < 0) { if (ret < 0) {
dev_err(&pdev->dev, "%s: Failed to reate sysfs group, %d\n", dev_err(&pdev->dev, "%s: Failed to reate sysfs group, %d\n",
__func__, ret); __func__, ret);
goto error; goto error;
} }
dev_info(&pdev->dev, "nvsciipc_uid sysfs group: done\n");
ret = alloc_chrdev_region(&(s_ctx->dev_t), 0, 1, MODULE_NAME); ret = alloc_chrdev_region(&(s_ctx->dev_t), 0, 1, MODULE_NAME);
if (ret != 0) { if (ret != 0) {
@@ -1186,7 +1183,6 @@ static struct platform_driver nvsciipc_driver = {
.shutdown = nvsciipc_shutdown, .shutdown = nvsciipc_shutdown,
.driver = { .driver = {
.name = MODULE_NAME, .name = MODULE_NAME,
.groups = nvsciipc_uid_groups,
}, },
#ifdef CONFIG_PM #ifdef CONFIG_PM
.suspend = nvsciipc_suspend, .suspend = nvsciipc_suspend,