From aafa45a665f5a014fe0fd151708efda0ff1ee5ee Mon Sep 17 00:00:00 2001 From: Ketan Patil Date: Mon, 7 Aug 2023 06:10:50 +0000 Subject: [PATCH] memory: tegra: Handle incorrect mc interrupt mask case Cert-C is flagging following issue in mc-err code: cert_exp33_c_violation: Using uninitialized value status_reg when calling mc_ch_readl. Fix the above issue by adding a default case for MC interrupt mask and return from there by printing the error. CID 681739 Change-Id: I6dfaa8e830b6b3545c0018a3ebaf2d1f208a1347 Signed-off-by: Ketan Patil Reviewed-on: https://git-master.nvidia.com/r/c/linux-t264/+/2950862 Reviewed-by: Sachin Nikam GVS: Gerrit_Virtual_Submit --- drivers/memory/tegra/private-soc/tegra264-mc-err.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/memory/tegra/private-soc/tegra264-mc-err.c b/drivers/memory/tegra/private-soc/tegra264-mc-err.c index ae792996..7dd7518b 100644 --- a/drivers/memory/tegra/private-soc/tegra264-mc-err.c +++ b/drivers/memory/tegra/private-soc/tegra264-mc-err.c @@ -773,6 +773,9 @@ void log_fault(struct tegra_mcerr *mc_err, u32 channel, unsigned long mcf_ch_int status_reg = MC_ERR_ROUTE_SANITY_STATUS_0; addr_reg = MC_ERR_ROUTE_SANITY_ADR_0; break; + default: + dev_err_ratelimited(mc_err->dev, "Incorrect MC interrupt mask\n"); + return; } value = mc_ch_readl(mc_err, channel, status_reg);