From c9f69ea5d81640c11a2c66a4c5136b9241164b2c Mon Sep 17 00:00:00 2001 From: Zhiyuan Wang Date: Mon, 7 Apr 2025 09:27:01 +0000 Subject: [PATCH] linux: kmd: static analysis TOP25 04/02 Part 9 fix CERT INT08-C under the following path: - drivers/platform/tegra/rtcpu/camera-diagnostics.c Jira CAMERASW-32960 Change-Id: I592cab86961df8e3a23d95acadced0717f424616 Signed-off-by: Zhiyuan Wang Reviewed-on: https://git-master.nvidia.com/r/c/linux-nv-oot/+/3334867 Reviewed-by: Semi Malinen Reviewed-by: svcacv Reviewed-by: Vishal Agrawal (SW) Reviewed-by: Frank Chen GVS: buildbot_gerritrpt Reviewed-by: Patrick Young --- drivers/platform/tegra/rtcpu/camera-diagnostics.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/platform/tegra/rtcpu/camera-diagnostics.c b/drivers/platform/tegra/rtcpu/camera-diagnostics.c index e61fd407..9dec4d4e 100644 --- a/drivers/platform/tegra/rtcpu/camera-diagnostics.c +++ b/drivers/platform/tegra/rtcpu/camera-diagnostics.c @@ -888,14 +888,17 @@ static ssize_t status_show(struct device *dev, struct device_attribute *attr, ch for (i = 0; i < ch->num_isp_instances; i++) { /* Skip second instance if not enabled */ if (i > 0 && !ISP_SECOND_INSTANCE_ENABLED) { - pos += sprintf(buf + pos, "\nISP%d: DISABLED\n", i); + int len = sprintf(buf + pos, "\nISP%d: DISABLED\n", i); + (void)__builtin_add_overflow(pos, len, &pos); continue; } start_time = jiffies; err = camera_diag_isp_sdl_status(ch, &status, i); - if (time_after(jiffies, start_time + msecs_to_jiffies(1000)) || err != 0) { + unsigned long end_time = 0U; + (void)__builtin_add_overflow(start_time, msecs_to_jiffies(1000), &end_time); + if (time_after(jiffies, end_time) || err != 0) { pos += sprintf(buf + pos, "\nISP%d: Error getting diagnostic status: %d\n", i, err); continue; }