From d7e0d5839392a57c2033c97a59e5de3fe1632f92 Mon Sep 17 00:00:00 2001 From: Mahesh Patil Date: Mon, 4 May 2020 16:02:35 -0700 Subject: [PATCH] nvethernet: Free skb for Rx error packets Issue: Driver does not free skb if OSI_PKT_CX_VALID is reset for Rx error packets. It can cause memory leak. Fix: Free Rx packet skb's for error packets Bug 2906694 Change-Id: I4364cf9d2974334d2b2d76bfcc22ef89ac406e8c Signed-off-by: Mahesh Patil Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvidia/+/2338963 Tested-by: mobile promotions Reviewed-by: mobile promotions --- drivers/net/ethernet/nvidia/nvethernet/osd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/nvidia/nvethernet/osd.c b/drivers/net/ethernet/nvidia/nvethernet/osd.c index 3887145a..0885adbd 100644 --- a/drivers/net/ethernet/nvidia/nvethernet/osd.c +++ b/drivers/net/ethernet/nvidia/nvethernet/osd.c @@ -289,6 +289,7 @@ void osd_receive_packet(void *priv, void *rxring, unsigned int chan, ndev->stats.rx_frame_errors = pkt_err_stat->rx_frame_error; ndev->stats.rx_fifo_errors = osi_core->mmc.mmc_rx_fifo_overflow; ndev->stats.rx_errors++; + dev_kfree_skb_any(skb); } ndev->stats.rx_packets++;