From d8c5cf13b7eeaa696558c6c535c9483d0a66decc Mon Sep 17 00:00:00 2001 From: Jon Hunter Date: Mon, 7 Oct 2024 10:01:25 +0100 Subject: [PATCH] net: rtl8852ce: Don't build driver for Linux v6.6+ Building the rtl8852ce driver with various different Linux v6.x kernels fail for various reasons. For Linux v6.6 the build fails with errors such as ... drivers/net/wireless/realtek/rtl8852ce/phl/phl_sta.c: In function 'phl_cmd_set_seciv_hdl': drivers/net/wireless/realtek/rtl8852ce/phl/phl_sta.c:4907:16: error: implicit conversion from 'enum rtw_hal_status' to 'enum rtw_phl_status' [-Werror=enum-conversion] 4907 | return rtw_hal_set_dctrl_tbl_seciv((void*)phl_info->hal, | sta, sta->sec_iv); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ For Linux v6.8 the build fails with the above and the following ... drivers/net/wireless/realtek/rtl8852ce/phl/phl_sta.c:301:5: error: no previous declaration for '_phl_get_macid' [-Werror=missing-declarations] 301 | u16 _phl_get_macid(struct phl_info_t *phl_info, | ^~~~~~~~~~~~~~ For Linux v6.10 the build fails with the above and the following ... drivers/net/wireless/realtek/rtl8852ce/core/rtw_ap.c:6265:9: error: suggest braces around empty body in an 'else' statement [-Werror=empty-body] 6265 | ; | ^ drivers/net/wireless/realtek/rtl8852ce/core/rtw_sta_mgt.c:742:1: error: 'static' is not at beginning of declaration [-Werror=old-style-declaration] 742 | u32 static _rtw_free_core_stainfo(_adapter *padapter , struct | sta_info *psta, u8 aid, | const u8 *hwaddr) | ^~~ For Linux v6.12, the driver build is completely broken because of the following build error ... drivers/net/wireless/realtek/rtl8852ce/os_dep/linux/wifi_regd.c:1007:17: error: too few arguments to function 'cfg80211_cac_event' 1007 | cfg80211_cac_event(evt->netdev, &evt->chandef, | evt->event, GFP_KERNEL); | ^~~~~~~~~~~~~~~~~~ For Linux v6.6+ mark the driver as broken and do not build this for Linux v6.6+ kernels until these issues are addressed. Bug 4667769 Change-Id: Id6b060f6b39ba4ef64d6388e06ef1e038c19206f Signed-off-by: Jon Hunter Reviewed-on: https://git-master.nvidia.com/r/c/linux-nv-oot/+/3226276 Reviewed-by: svcacv GVS: buildbot_gerritrpt Reviewed-by: Brad Griffis --- drivers/net/wireless/realtek/Makefile | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/wireless/realtek/Makefile b/drivers/net/wireless/realtek/Makefile index 84053dda..cc8a9e60 100644 --- a/drivers/net/wireless/realtek/Makefile +++ b/drivers/net/wireless/realtek/Makefile @@ -1,11 +1,16 @@ # SPDX-License-Identifier: GPL-2.0-only # SPDX-FileCopyrightText: Copyright (c) 2022-2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved. +LINUX_VERSION := $(shell expr $(VERSION) \* 256 + $(PATCHLEVEL)) +LINUX_VERSION_6_6 := $(shell expr 6 \* 256 + 6) + ifeq ($(findstring ack_src,$(NV_BUILD_KERNEL_OPTIONS)),) ifeq ($(VERSION).$(PATCHLEVEL),5.15) ifneq ($(NV_OOT_REALTEK_RTL8822CE_SKIP_BUILD),y) obj-m += rtl8822ce/ endif endif +ifeq ($(shell test $(LINUX_VERSION) -lt $(LINUX_VERSION_6_6); echo $$?),0) obj-m += rtl8852ce/ endif +endif