From dd7632c195326bd20efd97be6ff1c05f0e361964 Mon Sep 17 00:00:00 2001 From: Rakesh Goyal Date: Thu, 5 Jan 2023 02:39:14 +0530 Subject: [PATCH] nvethernet: fix syntax error in fpe ioctl Issue: Due to syntax error, only 1 byte getting copied from user space to kernel space. Fix: Fix syntax error. Add error logs Bug 3991771 Change-Id: Iff96d0f51605fab2954c1c9a423ad9a6781c1e21 Signed-off-by: Revanth Kumar Uppala Reviewed-on: https://git-master.nvidia.com/r/c/linux-nv-oot/+/2866442 Reviewed-by: Narayan Reddy Reviewed-by: svc-mobile-coverity Reviewed-by: svc-mobile-cert Reviewed-by: Rakesh Goyal Reviewed-by: Bitan Biswas GVS: Gerrit_Virtual_Submit --- drivers/net/ethernet/nvidia/nvethernet/ioctl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/nvidia/nvethernet/ioctl.c b/drivers/net/ethernet/nvidia/nvethernet/ioctl.c index 1b9c0213..09ef14d7 100644 --- a/drivers/net/ethernet/nvidia/nvethernet/ioctl.c +++ b/drivers/net/ethernet/nvidia/nvethernet/ioctl.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-only -/* Copyright (c) 2019-2022, NVIDIA CORPORATION & AFFILIATES. All rights reserved */ +/* Copyright (c) 2019-2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved */ #include "ether_linux.h" @@ -976,7 +976,8 @@ static int ether_config_fpe(struct net_device *dev, } if (copy_from_user(&ioctl_data.fpe, (void __user *)u_fpe_cfg, - sizeof(struct osi_fpe_config) != 0U)) { + sizeof(struct osi_fpe_config)) != 0U) { + dev_err(pdata->dev, "%s: copy_from_user error\n", __func__); return -EFAULT; }