The compiler option -Wmissing-prototypes is being enabled globally in
the upstream Linux kernel and this causes build failures for various
drivers. The build failures occur because either the driver is missing
an include file which has the prototype or because the function is not
declared statically when it should be (ie. there are no external users).
Fix the various build failures and enable -Wmissing-prototypes to
prevent any new instances from occurring. Note that the only driver that
is not fixed at the moment is rtl8822ce due to large number of failures
and so build this with '-Wno-missing-prototypes' for now, which is not
different to how it was being compiled prior to this change.
Bug 4404965
Change-Id: Ie5572d23659e0346fa035d645d9043b0a6da5fdc
Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nv-oot/+/3027488
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Building the realtek wireless driver generates various warnings due to
incorrect indentation or missing curly braces. For example, the
following warnings are seen ...
drivers/net/wireless/realtek/rtl8822ce/core/rtw_mlme.c: In function
‘rtw_drv_scan_by_self’:
drivers/net/wireless/realtek/rtl8822ce/core/rtw_mlme.c:3167:17:
warning: this ‘else’ clause does not guard... [-Wmisleading-indentation]
3167 | else
| ^~~~
drivers/net/wireless/realtek/rtl8822ce/core/rtw_mlme.c:3170:25:
note: ...this statement, but the latter is misleadingly indented as if
it were guarded by the ‘else’
3170 | goto exit;
| ^~~~
drivers/net/wireless/realtek/rtl8822ce/core/efuse/rtw_efuse.c:917:17:
warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
917 | if (i % 16 == 0)
| ^~
Fix the indentation and add the necessary curly braces to resolve these
warnings.
Bug 4190030
Change-Id: Ic13f1470043190ffd8401581cb97c908070c2940
Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nv-oot/+/2934697
Reviewed-by: Revanth Kumar Uppala <ruppala@nvidia.com>
Reviewed-by: Shobek Attupurath <sattupurath@nvidia.com>
GVS: Gerrit_Virtual_Submit <buildbot_gerritrpt@nvidia.com>
