mirror of
git://nv-tegra.nvidia.com/linux-nv-oot.git
synced 2025-12-24 10:11:26 +03:00
c920508259
Sparse generates the following warnings for the CVNAS driver ... drivers/platform/tegra/cvnas/cvnas.c:126:5: warning: symbol 'nvcvnas_busy' was not declared. Should it be static? drivers/platform/tegra/cvnas/cvnas.c:138:5: warning: symbol 'nvcvnas_idle' was not declared. Should it be static? drivers/platform/tegra/cvnas/cvnas.c:444:13: warning: symbol 'nvcvnas_get_cvsram_base' was not declared. Should it be static? drivers/platform/tegra/cvnas/cvnas.c:456:8: warning: symbol 'nvcvnas_get_cvsram_size' was not declared. Should it be static? drivers/platform/tegra/cvnas/cvnas.c:468:5: warning: symbol 'is_nvcvnas_probed' was not declared. Should it be static? drivers/platform/tegra/cvnas/cvnas.c:476:5: warning: symbol 'is_nvcvnas_clk_enabled' was not declared. Should it be static? drivers/platform/tegra/cvnas/cvnas.c:779:5: warning: symbol 'nvcvnas_busy_no_rpm' was not declared. Should it be static? drivers/platform/tegra/cvnas/cvnas.c:793:5: warning: symbol 'nvcvnas_idle_no_rpm' was not declared. Should it be static? There are a few problems here which are: 1. The CVNAS driver does not include the 'cvnas.h' header file and so some of the declarations are not found. 2. Some of the CVNAS functions are not declared in the 'cvnas.h' header file and need to be added. 3. The Tegra19x CBB driver is a user of these CVNAS functions, but instead of including the 'cvnas.h' file it defines prototypes for these functions. This is not necessary and so we can remove these prototypes and simply include the 'cvnas.h' header file. 4. The function definition nvcvnas_idle_no_rpm() in the CVNAS driver is incorrect and this function should not have any arguments passed to it and currently does not match the prototype. Bug 3528414 Change-Id: I7945f8c66ceb5ca5b158b7ed1b81a50f19c52bb7 Signed-off-by: Jon Hunter <jonathanh@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvidia/+/2670149 Reviewed-by: Ketan Patil <ketanp@nvidia.com> Reviewed-by: Sachin Nikam <snikam@nvidia.com>
35 lines
974 B
C
35 lines
974 B
C
/*
|
|
* include/linux/cvnas.h
|
|
*
|
|
* Tegra cvnas driver
|
|
*
|
|
* Copyright (c) 2018-2022, NVIDIA Corporation. All rights reserved.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful, but WITHOUT
|
|
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
|
|
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
|
|
* more details.
|
|
*
|
|
*/
|
|
|
|
#ifndef __LINUX_CVNAS_H
|
|
#define __LINUX_CVNAS_H
|
|
|
|
#include <linux/types.h>
|
|
|
|
int nvcvnas_busy(void);
|
|
int nvcvnas_busy_no_rpm(void);
|
|
int nvcvnas_idle(void);
|
|
int nvcvnas_idle_no_rpm(void);
|
|
int is_nvcvnas_probed(void);
|
|
phys_addr_t nvcvnas_get_cvsram_base(void);
|
|
size_t nvcvnas_get_cvsram_size(void);
|
|
int is_nvcvnas_clk_enabled(void);
|
|
|
|
#endif
|