mirror of
git://nv-tegra.nvidia.com/linux-nv-oot.git
synced 2025-12-22 17:25:35 +03:00
Fix camera kernel drivers for the below warnings: CID 10165214: Unchecked return value (CHECKED_RETURN) CID 10165215: Unchecked return value (CHECKED_RETURN) CID 10160154: Unsigned compared against 0 (NO_EFFECT) Bug 3952896 Change-Id: I82727b5c298d0c39ebba2ae60f6ed76321272ff5 Signed-off-by: Frank Chen <frankc@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/c/linux-nv-oot/+/2858894 GVS: Gerrit_Virtual_Submit <buildbot_gerritrpt@nvidia.com> Reviewed-by: Vincent Chung <vincentc@nvidia.com> Reviewed-by: Sachin Nikam <snikam@nvidia.com>
257 lines
5.3 KiB
C
257 lines
5.3 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
// Copyright (c) 2022-2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
|
|
|
|
#include "clk-group.h"
|
|
|
|
#include <linux/device.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/of.h>
|
|
#include <linux/clk.h>
|
|
#include <linux/limits.h>
|
|
#include <linux/module.h>
|
|
|
|
struct camrtc_clk_group {
|
|
struct device *device;
|
|
struct {
|
|
struct clk *slow;
|
|
struct clk *fast;
|
|
} parents;
|
|
u32 nclocks;
|
|
struct {
|
|
struct clk *clk;
|
|
u32 slow;
|
|
u32 fast;
|
|
} clocks[];
|
|
};
|
|
|
|
static void camrtc_clk_group_release(struct device *dev, void *res)
|
|
{
|
|
const struct camrtc_clk_group *grp = res;
|
|
int i;
|
|
|
|
for (i = 0; i < grp->nclocks; i++) {
|
|
if (grp->clocks[i].clk)
|
|
clk_put(grp->clocks[i].clk);
|
|
}
|
|
|
|
if (grp->parents.slow)
|
|
clk_put(grp->parents.slow);
|
|
if (grp->parents.fast)
|
|
clk_put(grp->parents.fast);
|
|
}
|
|
|
|
static int camrtc_clk_group_get_parent(
|
|
struct device_node *np,
|
|
int index,
|
|
struct clk **return_clk)
|
|
{
|
|
struct of_phandle_args clkspec;
|
|
struct clk *clk;
|
|
int ret;
|
|
|
|
if (index < 0)
|
|
return -EINVAL;
|
|
|
|
ret = of_parse_phandle_with_args(np,
|
|
"nvidia,clock-parents", "#clock-cells", index,
|
|
&clkspec);
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
clk = of_clk_get_from_provider(&clkspec);
|
|
of_node_put(clkspec.np);
|
|
|
|
if (IS_ERR(clk))
|
|
return PTR_ERR(clk);
|
|
|
|
*return_clk = clk;
|
|
|
|
return 0;
|
|
}
|
|
|
|
struct camrtc_clk_group *camrtc_clk_group_get(
|
|
struct device *dev)
|
|
{
|
|
struct camrtc_clk_group *grp;
|
|
struct device_node *np;
|
|
int nclocks;
|
|
int nrates;
|
|
int nparents;
|
|
u32 index;
|
|
int ret;
|
|
|
|
if (!dev || !dev->of_node)
|
|
return ERR_PTR(-EINVAL);
|
|
|
|
np = dev->of_node;
|
|
|
|
nclocks = of_property_count_strings(np, "clock-names");
|
|
if (nclocks < 0 || nclocks > (S32_MAX / sizeof(grp->clocks[0])))
|
|
return ERR_PTR(-ENOENT);
|
|
|
|
/* This has pairs of u32s: slow and fast rate for each clock */
|
|
nrates = of_property_count_u64_elems(np, "nvidia,clock-rates");
|
|
/* of_property_count_elems_of_size() already complains about this */
|
|
if (nrates < 0)
|
|
nrates = 0;
|
|
|
|
nparents = of_count_phandle_with_args(np, "nvidia,clock-parents",
|
|
"#clock-cells");
|
|
if (nparents > 0 && nparents != 2)
|
|
dev_warn(dev, "expecting exactly two \"%s\"\n",
|
|
"nvidia,clock-parents");
|
|
|
|
grp = devres_alloc(camrtc_clk_group_release,
|
|
sizeof(*grp) +
|
|
nclocks * sizeof(grp->clocks[0]),
|
|
GFP_KERNEL);
|
|
if (!grp)
|
|
return ERR_PTR(-ENOMEM);
|
|
|
|
grp->nclocks = nclocks;
|
|
grp->device = dev;
|
|
|
|
for (index = 0; index < nclocks; index++) {
|
|
struct clk *clk;
|
|
|
|
clk = of_clk_get(np, index);
|
|
if (IS_ERR(clk)) {
|
|
ret = PTR_ERR(clk);
|
|
goto error;
|
|
}
|
|
|
|
grp->clocks[index].clk = clk;
|
|
|
|
if (index >= nrates)
|
|
continue;
|
|
|
|
if (of_property_read_u32_index(np, "nvidia,clock-rates",
|
|
2 * index, &grp->clocks[index].slow))
|
|
dev_warn(dev, "clock-rates property not found\n");
|
|
if (of_property_read_u32_index(np, "nvidia,clock-rates",
|
|
2 * index + 1, &grp->clocks[index].fast))
|
|
dev_warn(dev, "clock-rates property not found\n");
|
|
}
|
|
|
|
if (nparents == 2) {
|
|
ret = camrtc_clk_group_get_parent(np, 0, &grp->parents.slow);
|
|
if (ret < 0)
|
|
goto error;
|
|
|
|
ret = camrtc_clk_group_get_parent(np, 1, &grp->parents.fast);
|
|
if (ret < 0)
|
|
goto error;
|
|
}
|
|
|
|
devres_add(dev, grp);
|
|
return grp;
|
|
|
|
error:
|
|
devres_free(grp);
|
|
return ERR_PTR(ret);
|
|
}
|
|
EXPORT_SYMBOL_GPL(camrtc_clk_group_get);
|
|
|
|
static void camrtc_clk_group_error(
|
|
const struct camrtc_clk_group *grp,
|
|
char const *op,
|
|
int index,
|
|
int error)
|
|
{
|
|
const char *name = "unnamed";
|
|
int ret;
|
|
|
|
ret = of_property_read_string_index(grp->device->of_node,
|
|
"clock-names", index, &name);
|
|
|
|
if (ret < 0)
|
|
dev_warn(grp->device, "Cannot find clock in clock-names\n");
|
|
|
|
dev_warn(grp->device, "%s clk %s (at [%d]): failed (%d)\n",
|
|
op, name, index, error);
|
|
}
|
|
|
|
int camrtc_clk_group_enable(const struct camrtc_clk_group *grp)
|
|
{
|
|
int index, err;
|
|
|
|
if (IS_ERR_OR_NULL(grp))
|
|
return -ENODEV;
|
|
|
|
for (index = 0; index < grp->nclocks; index++) {
|
|
err = clk_prepare_enable(grp->clocks[index].clk);
|
|
if (err) {
|
|
camrtc_clk_group_error(grp, "enable", index, err);
|
|
return err;
|
|
}
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
EXPORT_SYMBOL_GPL(camrtc_clk_group_enable);
|
|
|
|
void camrtc_clk_group_disable(const struct camrtc_clk_group *grp)
|
|
{
|
|
int index;
|
|
|
|
if (IS_ERR_OR_NULL(grp))
|
|
return;
|
|
|
|
for (index = 0; index < grp->nclocks; index++)
|
|
clk_disable_unprepare(grp->clocks[index].clk);
|
|
}
|
|
EXPORT_SYMBOL_GPL(camrtc_clk_group_disable);
|
|
|
|
static void camrtc_clk_group_set_parent(const struct camrtc_clk_group *grp,
|
|
struct clk *parent)
|
|
{
|
|
int index;
|
|
|
|
if (IS_ERR_OR_NULL(parent))
|
|
return;
|
|
|
|
for (index = 0; index < grp->nclocks; index++)
|
|
clk_set_parent(grp->clocks[index].clk, parent);
|
|
}
|
|
|
|
int camrtc_clk_group_adjust_slow(const struct camrtc_clk_group *grp)
|
|
{
|
|
int index;
|
|
|
|
if (IS_ERR_OR_NULL(grp))
|
|
return -ENODEV;
|
|
|
|
for (index = 0; index < grp->nclocks; index++) {
|
|
u32 slow = grp->clocks[index].slow;
|
|
|
|
if (slow != 0)
|
|
clk_set_rate(grp->clocks[index].clk, slow);
|
|
}
|
|
|
|
camrtc_clk_group_set_parent(grp, grp->parents.slow);
|
|
|
|
return 0;
|
|
}
|
|
EXPORT_SYMBOL_GPL(camrtc_clk_group_adjust_slow);
|
|
|
|
int camrtc_clk_group_adjust_fast(const struct camrtc_clk_group *grp)
|
|
{
|
|
int index;
|
|
|
|
if (IS_ERR_OR_NULL(grp))
|
|
return -ENODEV;
|
|
|
|
camrtc_clk_group_set_parent(grp, grp->parents.fast);
|
|
|
|
for (index = 0; index < grp->nclocks; index++) {
|
|
u32 fast = grp->clocks[index].fast;
|
|
|
|
if (fast != 0)
|
|
clk_set_rate(grp->clocks[index].clk, fast);
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
EXPORT_SYMBOL_GPL(camrtc_clk_group_adjust_fast);
|
|
MODULE_LICENSE("GPL v2");
|