mirror of
git://nv-tegra.nvidia.com/linux-nv-oot.git
synced 2025-12-22 17:25:35 +03:00
Once we complete EVENT_ID_DCE_BOOT_COMPLETE_RECEIVED event handling, it doesn't reset the complition variable. Which causes dce_wait_interruptible to exit early without waiting in next cycle. This patch fixes the same by resetting complition variable after use for EVENT_ID_DCE_BOOT_COMPLETE_RECEIVED. Bug 4167219 Change-Id: Id9b9047fa0e293f8616e23a5c8b4b1bacf233934 Signed-off-by: Mahesh Kumar <mahkumar@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/c/linux-nv-oot/+/2927740 Reviewed-by: svcacv <svcacv@nvidia.com> Reviewed-by: Arun Swain <arswain@nvidia.com> GVS: Gerrit_Virtual_Submit <buildbot_gerritrpt@nvidia.com>
176 lines
3.8 KiB
C
176 lines
3.8 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Copyright (c) 2019-2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
|
|
*/
|
|
|
|
#include <dce.h>
|
|
#include <dce-cond.h>
|
|
#include <dce-lock.h>
|
|
#include <dce-worker.h>
|
|
#include <dce-util-common.h>
|
|
#include <interface/dce-admin-cmds.h>
|
|
|
|
/*
|
|
* dce_wait_interruptible : Wait for a given condition
|
|
*
|
|
* @d : Pointer to tegra_dce struct.
|
|
* @msg_id : index of wait condition
|
|
*
|
|
* Return : 0 if successful else error code
|
|
*/
|
|
int dce_wait_interruptible(struct tegra_dce *d, u32 msg_id)
|
|
{
|
|
struct dce_wait_cond *wait;
|
|
|
|
if (msg_id >= DCE_MAX_WAIT) {
|
|
dce_err(d, "Invalid wait requested %u", msg_id);
|
|
return -EINVAL;
|
|
}
|
|
|
|
wait = &d->ipc_waits[msg_id];
|
|
|
|
/*
|
|
* It is possible that we received the ACK from DCE even before we
|
|
* start waiting. But that should not be an issue as wait->complete
|
|
* Will be "1" and we immediately exit from the wait.
|
|
*/
|
|
DCE_COND_WAIT_INTERRUPTIBLE(&wait->cond_wait,
|
|
atomic_read(&wait->complete) == 1);
|
|
|
|
if (atomic_read(&wait->complete) != 1)
|
|
return -EINTR;
|
|
|
|
/*
|
|
* Clear wait->complete as soon as we exit from wait (consume the wake call)
|
|
* So that when the next dce_wait_interruptible is called, it doesn't see old
|
|
* wait->complete state.
|
|
*/
|
|
atomic_set(&wait->complete, 0);
|
|
return 0;
|
|
}
|
|
|
|
/*
|
|
* dce_wakeup_interruptible : Wakeup waiting task on given condition
|
|
*
|
|
* @d : Pointer to tegra_dce struct.
|
|
* @msg_id : index of wait condition
|
|
*
|
|
* Return : void
|
|
*/
|
|
void dce_wakeup_interruptible(struct tegra_dce *d, u32 msg_id)
|
|
{
|
|
struct dce_wait_cond *wait;
|
|
|
|
if (msg_id >= DCE_MAX_WAIT) {
|
|
dce_err(d, "Invalid wait requested %u", msg_id);
|
|
return;
|
|
}
|
|
|
|
wait = &d->ipc_waits[msg_id];
|
|
|
|
/*
|
|
* Set wait->complete to "1", so if the wait is called even after
|
|
* "dce_cond_signal_interruptible", it'll see the complete variable
|
|
* as "1" and exit the wait immediately.
|
|
*/
|
|
atomic_set(&wait->complete, 1);
|
|
dce_cond_signal_interruptible(&wait->cond_wait);
|
|
}
|
|
|
|
/*
|
|
* dce_cond_wait_reset : reset condition wait variable to zero
|
|
*
|
|
* @d : Pointer to tegra_dce struct.
|
|
* @msg_id : index of wait condition
|
|
*
|
|
* Return : void
|
|
*/
|
|
void dce_cond_wait_reset(struct tegra_dce *d, u32 msg_id)
|
|
{
|
|
struct dce_wait_cond *wait;
|
|
|
|
if (msg_id >= DCE_MAX_WAIT) {
|
|
dce_err(d, "Invalid wait requested %u", msg_id);
|
|
return;
|
|
}
|
|
|
|
wait = &d->ipc_waits[msg_id];
|
|
atomic_set(&wait->complete, 0);
|
|
}
|
|
|
|
/**
|
|
* dce_work_cond_sw_resource_init : Init dce workqueues related resources
|
|
*
|
|
* @d : Pointer to tegra_dce struct.
|
|
*
|
|
* Return : 0 if successful else error code
|
|
*/
|
|
int dce_work_cond_sw_resource_init(struct tegra_dce *d)
|
|
{
|
|
int ret = 0;
|
|
int i;
|
|
|
|
ret = dce_init_work(d, &d->dce_bootstrap_work, dce_bootstrap_work_fn);
|
|
if (ret) {
|
|
dce_err(d, "Bootstrap work init failed");
|
|
goto exit;
|
|
}
|
|
|
|
ret = dce_init_work(d, &d->dce_resume_work, dce_resume_work_fn);
|
|
if (ret) {
|
|
dce_err(d, "resume work init failed");
|
|
goto exit;
|
|
}
|
|
|
|
if (dce_cond_init(&d->dce_bootstrap_done)) {
|
|
dce_err(d, "dce boot wait condition init failed");
|
|
ret = -1;
|
|
goto exit;
|
|
}
|
|
|
|
for (i = 0; i < DCE_MAX_WAIT; i++) {
|
|
struct dce_wait_cond *wait = &d->ipc_waits[i];
|
|
|
|
if (dce_cond_init(&wait->cond_wait)) {
|
|
dce_err(d, "dce wait condition %d init failed", i);
|
|
ret = -1;
|
|
goto init_error;
|
|
}
|
|
|
|
atomic_set(&wait->complete, 0);
|
|
}
|
|
|
|
return 0;
|
|
init_error:
|
|
while (i >= 0) {
|
|
struct dce_wait_cond *wait = &d->ipc_waits[i];
|
|
|
|
dce_cond_destroy(&wait->cond_wait);
|
|
i--;
|
|
}
|
|
dce_cond_destroy(&d->dce_bootstrap_done);
|
|
exit:
|
|
return ret;
|
|
}
|
|
|
|
/**
|
|
* dce_work_cond_sw_resource_deinit : de-init dce workqueues related resources
|
|
*
|
|
* @d : Pointer to tegra_dce struct.
|
|
*
|
|
* Return : void
|
|
*/
|
|
void dce_work_cond_sw_resource_deinit(struct tegra_dce *d)
|
|
{
|
|
int i;
|
|
|
|
for (i = 0; i < DCE_MAX_WAIT; i++) {
|
|
struct dce_wait_cond *wait = &d->ipc_waits[i];
|
|
|
|
dce_cond_destroy(&wait->cond_wait);
|
|
atomic_set(&wait->complete, 0);
|
|
}
|
|
|
|
dce_cond_destroy(&d->dce_bootstrap_done);
|
|
}
|