mirror of
git://nv-tegra.nvidia.com/linux-nv-oot.git
synced 2025-12-22 09:11:26 +03:00
fc7367debb
If probing of the VIC engine fails then the following crash is observed ... tegra-vic 15340000.vic: devfreq_add_device: Unable to find governor for the device tegra-vic 15340000.vic: failed to init devfreq: -22 tegra-vic: probe of 15340000.vic failed with error -22 tegra-nvdec 15480000.nvdec: Adding to iommu group 45 list_add corruption. prev->next should be next (ffff000094505f80), but was 0000000000000000. (prev=ffff000095245cf0). ------------[ cut here ]------------ kernel BUG at lib/list_debug.c:26! Internal error: Oops - BUG: 00000000f2000800 [#1] SMP ... pc : __list_add_valid+0x80/0x84 lr : __list_add_valid+0x80/0x84 ... Call trace: __list_add_valid+0x80/0x84 host1x_subdev_register+0x80/0x170 [host1x_next] __host1x_client_register+0xac/0x160 [host1x_next] nvdec_probe+0x1c8/0x58c [tegra_drm_next] platform_probe+0x6c/0xe0 really_probe+0xc4/0x3dc __driver_probe_device+0x114/0x190 driver_probe_device+0x44/0x114 __driver_attach+0xcc/0x1f0 bus_for_each_dev+0x78/0xd0 driver_attach+0x28/0x30 bus_add_driver+0xbc/0x220 driver_register+0x70/0x120 __platform_register_drivers+0x70/0x140 host1x_drm_init+0x58/0x1000 [tegra_drm_next] do_one_initcall+0x48/0x2d0 do_init_module+0x5c/0x270 load_module+0xb08/0xc70 __do_sys_init_module+0x1dc/0x214 __arm64_sys_init_module+0x20/0x2c invoke_syscall.constprop.0+0x7c/0xd0 el0_svc_common.constprop.0+0x140/0x150 do_el0_svc+0x38/0xa0 el0_svc+0x38/0x18c el0t_64_sync_handler+0xb4/0x130 el0t_64_sync+0x17c/0x180 Code: aa0103e2 910fa000 aa0403e1 941b9509 (d4210000) ---[ end trace f8f20f933fe03c7e ]--- The problem is that some of the engines are not cleaning up correctly on probe failure and so fix this by adding the necessary calls clean up if probe fails. Bug 4303860 Change-Id: Ife1e0ce7429458d187422162a298cc140f0e3bc4 Signed-off-by: Jon Hunter <jonathanh@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/c/linux-nv-oot/+/2986790 Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com> GVS: Gerrit_Virtual_Submit <buildbot_gerritrpt@nvidia.com>