nv-tegra-mirror/linux-nvgpu
1
0
Fork 0
mirror of git://nv-tegra.nvidia.com/linux-nvgpu.git synced 2025-12-22 17:36:20 +03:00
Code Issues Packages Projects Releases Wiki Activity

gpu: nvgpu: Remove hard coded constants from PMU

Browse Source 
During code inspection use of some hard coded
constants was found in some parts of the code.
Those constants are replaced by macros

JIRA NVGPU-5031

Change-Id: I50821839bc36c8d28b3e8678abdf82a856b9d8d2
Signed-off-by: Divya Singhatwaria <dsinghatwari@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvgpu/+/2300562
Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com>
Reviewed-by: svc-mobile-misra <svc-mobile-misra@nvidia.com>
Reviewed-by: Mahantesh Kumbar <mkumbar@nvidia.com>
Reviewed-by: Vijayakumar Subbu <vsubbu@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
GVS: Gerrit_Virtual_Submit
This commit is contained in:
Divya Singhatwaria
2020-02-20 17:41:12 +05:30
committed by Alex Waterman
parent ed4eb79ac1
commit 00b7ea7f13
1 changed files with 18 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
drivers/gpu/nvgpu/hal/pmu/pmu_gv11b_fusa.c
View File

@@ -33,10 +33,12 @@
#include <nvgpu/pmu/cmd.h> #include <nvgpu/pmu/cmd.h>
#endif #endif
#include "pmu_gv11b.h"
#include <nvgpu/hw/gv11b/hw_pwr_gv11b.h> #include <nvgpu/hw/gv11b/hw_pwr_gv11b.h>
#include "pmu_gv11b.h"
#define PWR_FALCON_MAILBOX1_DATA_INIT (0U)
#define PMU_BAR0_HOST_READ_ERROR (0U)
#define ALIGN_4KB 12 #define ALIGN_4KB 12
/* error handler */ /* error handler */
@@ -50,27 +52,32 @@ void gv11b_clear_pmu_bar0_host_err_status(struct gk20a *g)
static u32 pmu_bar0_host_tout_etype(u32 val) static u32 pmu_bar0_host_tout_etype(u32 val)
{ {
return (val != 0U) ? PMU_BAR0_HOST_WRITE_TOUT : PMU_BAR0_HOST_READ_TOUT; return (val != PMU_BAR0_HOST_READ_ERROR) ?
PMU_BAR0_HOST_WRITE_TOUT : PMU_BAR0_HOST_READ_TOUT;
} }
static u32 pmu_bar0_fecs_tout_etype(u32 val) static u32 pmu_bar0_fecs_tout_etype(u32 val)
{ {
return (val != 0U) ? PMU_BAR0_FECS_WRITE_TOUT : PMU_BAR0_FECS_READ_TOUT; return (val != PMU_BAR0_HOST_READ_ERROR) ?
PMU_BAR0_FECS_WRITE_TOUT : PMU_BAR0_FECS_READ_TOUT;
} }
static u32 pmu_bar0_cmd_hwerr_etype(u32 val) static u32 pmu_bar0_cmd_hwerr_etype(u32 val)
{ {
return (val != 0U) ? PMU_BAR0_CMD_WRITE_HWERR : PMU_BAR0_CMD_READ_HWERR; return (val != PMU_BAR0_HOST_READ_ERROR) ?
PMU_BAR0_CMD_WRITE_HWERR : PMU_BAR0_CMD_READ_HWERR;
} }
static u32 pmu_bar0_fecserr_etype(u32 val) static u32 pmu_bar0_fecserr_etype(u32 val)
{ {
return (val != 0U) ? PMU_BAR0_WRITE_FECSERR : PMU_BAR0_READ_FECSERR; return (val != PMU_BAR0_HOST_READ_ERROR) ?
PMU_BAR0_WRITE_FECSERR : PMU_BAR0_READ_FECSERR;
} }
static u32 pmu_bar0_hosterr_etype(u32 val) static u32 pmu_bar0_hosterr_etype(u32 val)
{ {
return (val != 0U) ? PMU_BAR0_WRITE_HOSTERR : PMU_BAR0_READ_HOSTERR; return (val != PMU_BAR0_HOST_READ_ERROR) ?
PMU_BAR0_WRITE_HOSTERR : PMU_BAR0_READ_HOSTERR;
} }
int gv11b_pmu_bar0_error_status(struct gk20a *g, u32 *bar0_status, int gv11b_pmu_bar0_error_status(struct gk20a *g, u32 *bar0_status,
@@ -200,7 +207,7 @@ void gv11b_pmu_flcn_setup_boot_config(struct gk20a *g)
} }
/* Clearing mailbox register used to reflect capabilities */ /* Clearing mailbox register used to reflect capabilities */
nvgpu_writel(g, pwr_falcon_mailbox1_r(), 0); nvgpu_writel(g, pwr_falcon_mailbox1_r(), PWR_FALCON_MAILBOX1_DATA_INIT);
/* enable the context interface */ /* enable the context interface */
nvgpu_writel(g, pwr_falcon_itfen_r(), nvgpu_writel(g, pwr_falcon_itfen_r(),
@@ -433,14 +440,14 @@ void gv11b_pmu_handle_ext_irq(struct gk20a *g, u32 intr0)
void gv11b_pmu_enable_irq(struct nvgpu_pmu *pmu, bool enable) void gv11b_pmu_enable_irq(struct nvgpu_pmu *pmu, bool enable)
{ {
struct gk20a *g = pmu->g; struct gk20a *g = pmu->g;
u32 intr_mask; u32 intr_mask = 0x0;
u32 intr_dest; u32 intr_dest = 0x0;
nvgpu_log_fn(g, " "); nvgpu_log_fn(g, " ");
nvgpu_mc_intr_stall_unit_config(g, MC_INTR_UNIT_PMU, MC_INTR_DISABLE); nvgpu_mc_intr_stall_unit_config(g, MC_INTR_UNIT_PMU, MC_INTR_DISABLE);
nvgpu_falcon_set_irq(pmu->flcn, false, 0x0, 0x0); nvgpu_falcon_set_irq(pmu->flcn, false, intr_mask, intr_dest);
if (enable) { if (enable) {
intr_dest = g->ops.pmu.get_irqdest(g); intr_dest = g->ops.pmu.get_irqdest(g);