nv-tegra-mirror/linux-nvgpu
1
0
Fork 0
mirror of git://nv-tegra.nvidia.com/linux-nvgpu.git synced 2025-12-22 09:12:24 +03:00
Code Issues Packages Projects Releases Wiki Activity

gpu: nvgpu: pmu: pmgr: fix taint parameter

Browse Source 
using nvgpu_memcpy() instead of downcasting the parameter to assign.

CID 10074974

Change-Id: I5ce333735dca5fc4e34dd42c9fca432223989bf2
Signed-off-by: rmylavarapu <rmylavarapu@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvgpu/+/2744418
Reviewed-by: svcacv <svcacv@nvidia.com>
Reviewed-by: Mahantesh Kumbar <mkumbar@nvidia.com>
Reviewed-by: Vaibhav Kachore <vkachore@nvidia.com>
GVS: Gerrit_Virtual_Submit
This commit is contained in:
rmylavarapu
2022-07-13 10:51:37 +00:00
committed by mobile promotions
parent d75473a115
commit 00fd453830
1 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
drivers/gpu/nvgpu/common/pmu/pmgr/pwrpolicy.c
View File

@@ -530,8 +530,8 @@ static int devinit_get_pwr_policy_table(struct gk20a *g,
int status = 0; int status = 0;
u8 *ptr = NULL; u8 *ptr = NULL;
struct pmu_board_obj *obj_tmp; struct pmu_board_obj *obj_tmp;
struct pwr_policy_3x_header_struct *packed_hdr; struct pwr_policy_3x_header_struct packed_hdr = { 0 };
struct pwr_policy_3x_header_unpacked hdr; struct pwr_policy_3x_header_unpacked hdr = { 0 };
u32 index; u32 index;
u32 obj_index = 0; u32 obj_index = 0;
size_t pwr_policy_size; size_t pwr_policy_size;
@@ -549,41 +549,41 @@ static int devinit_get_pwr_policy_table(struct gk20a *g,
goto done; goto done;
} }
packed_hdr = (struct pwr_policy_3x_header_struct *)ptr; nvgpu_memcpy((u8 *)&packed_hdr, ptr, VBIOS_POWER_POLICY_3X_HEADER_SIZE_25);
if (packed_hdr->version != if (packed_hdr.version !=
VBIOS_POWER_POLICY_VERSION_3X) { VBIOS_POWER_POLICY_VERSION_3X) {
status = -EINVAL; status = -EINVAL;
goto done; goto done;
} }
if (packed_hdr->header_size < if (packed_hdr.header_size <
VBIOS_POWER_POLICY_3X_HEADER_SIZE_25) { VBIOS_POWER_POLICY_3X_HEADER_SIZE_25) {
status = -EINVAL; status = -EINVAL;
goto done; goto done;
} }
if (packed_hdr->table_entry_size < if (packed_hdr.table_entry_size <
VBIOS_POWER_POLICY_3X_ENTRY_SIZE_2E) { VBIOS_POWER_POLICY_3X_ENTRY_SIZE_2E) {
status = -EINVAL; status = -EINVAL;
goto done; goto done;
} }
/* unpack power policy table header */ /* unpack power policy table header */
devinit_unpack_pwr_policy_header(&hdr, packed_hdr); devinit_unpack_pwr_policy_header(&hdr, &packed_hdr);
ptr += (u32)hdr.header_size; ptr += (u32)hdr.header_size;
for (index = 0; index < hdr.num_table_entries; index++) { for (index = 0; index < hdr.num_table_entries; index++) {
struct pwr_policy_3x_entry_struct *packed_entry; struct pwr_policy_3x_entry_struct packed_entry = { 0 };
struct pwr_policy_3x_entry_unpacked entry; struct pwr_policy_3x_entry_unpacked entry;
u8 class_type; u8 class_type;
packed_entry = (struct pwr_policy_3x_entry_struct *)ptr; nvgpu_memcpy((u8 *)&packed_entry, ptr, hdr.table_entry_size);
class_type = BIOS_GET_FIELD(u8, packed_entry->flags0, class_type = BIOS_GET_FIELD(u8, packed_entry.flags0,
NV_VBIOS_POWER_POLICY_3X_ENTRY_FLAGS0_CLASS); NV_VBIOS_POWER_POLICY_3X_ENTRY_FLAGS0_CLASS);
if (class_type != NV_VBIOS_POWER_POLICY_3X_ENTRY_FLAGS0_CLASS_HW_THRESHOLD) { if (class_type != NV_VBIOS_POWER_POLICY_3X_ENTRY_FLAGS0_CLASS_HW_THRESHOLD) {
@@ -592,7 +592,7 @@ static int devinit_get_pwr_policy_table(struct gk20a *g,
} }
/* unpack power policy table entry */ /* unpack power policy table entry */
devinit_unpack_pwr_policy_entry(&entry, packed_entry); devinit_unpack_pwr_policy_entry(&entry, &packed_entry);
ppwrpolicyobjs->version = ppwrpolicyobjs->version =
CTRL_PMGR_PWR_POLICY_TABLE_VERSION_3X; CTRL_PMGR_PWR_POLICY_TABLE_VERSION_3X;