From 0a013812a54cfde398fc9d4bcd5da01cddece9a8 Mon Sep 17 00:00:00 2001 From: Scott Long Date: Wed, 4 Sep 2019 10:03:52 -0700 Subject: [PATCH] gpu: nvgpu: falcon: fix misra 5.9 violation Advisory Rule 5.9 states that identifiers that define objects or functions with internal linkage should be unique. This change eliminates an Advisory Rule 5.9 violation in our falcon code involving falcon_sw_init() by renaming it to falcon_sw_chip_init(). Jira NVGPU-3178 Change-Id: Ia064f383131ad3a7db56b5dcc02c754a7cc3e6f6 Signed-off-by: Scott Long Reviewed-on: https://git-master.nvidia.com/r/2190094 Reviewed-by: Automatic_Commit_Validation_User Reviewed-by: svc-mobile-coverity Reviewed-by: svc-mobile-misra GVS: Gerrit_Virtual_Submit Reviewed-by: Thomas Fleury Reviewed-by: Adeel Raza Reviewed-by: mobile promotions Tested-by: mobile promotions --- drivers/gpu/nvgpu/common/falcon/falcon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/nvgpu/common/falcon/falcon.c b/drivers/gpu/nvgpu/common/falcon/falcon.c index 080e3092d..d5677a012 100644 --- a/drivers/gpu/nvgpu/common/falcon/falcon.c +++ b/drivers/gpu/nvgpu/common/falcon/falcon.c @@ -428,7 +428,7 @@ struct nvgpu_falcon *nvgpu_falcon_get_instance(struct gk20a *g, u32 flcn_id) return flcn; } -static int falcon_sw_init(struct gk20a *g, struct nvgpu_falcon *flcn) +static int falcon_sw_chip_init(struct gk20a *g, struct nvgpu_falcon *flcn) { u32 ver = nvgpu_safe_add_u32(g->params.gpu_arch, g->params.gpu_impl); int err = 0; @@ -474,7 +474,7 @@ int nvgpu_falcon_sw_init(struct gk20a *g, u32 flcn_id) flcn->g = g; /* call SW init methods to assign flcn base & support of a falcon */ - err = falcon_sw_init(g, flcn); + err = falcon_sw_chip_init(g, flcn); if (err != 0) { nvgpu_err(g, "Chip specific falcon sw init failed %d", err); return err;