From 10006b723a7a902dc51e2146a01b10e6e7663d4c Mon Sep 17 00:00:00 2001 From: Philip Elcan Date: Mon, 13 May 2019 15:46:22 -0400 Subject: [PATCH] gpu: nvgpu: mm: fix MISRA 21.6 violations in vm.c MISRA 21.6 prohibits use of snprintf(). Replace uses with strcpy/strcat. JIRA NVGPU-3332 Change-Id: I795b673d0a855c0fcb28fac76b31ef1b1f39543e Signed-off-by: Philip Elcan Reviewed-on: https://git-master.nvidia.com/r/2119633 GVS: Gerrit_Virtual_Submit Reviewed-by: Deepak Nibade Reviewed-by: Vinod Gopalakrishnakurup Reviewed-by: mobile promotions Tested-by: mobile promotions --- drivers/gpu/nvgpu/common/mm/vm.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/nvgpu/common/mm/vm.c b/drivers/gpu/nvgpu/common/mm/vm.c index d6b1dba2c..19d89e15e 100644 --- a/drivers/gpu/nvgpu/common/mm/vm.c +++ b/drivers/gpu/nvgpu/common/mm/vm.c @@ -457,8 +457,8 @@ int nvgpu_vm_do_init(struct mm_gk20a *mm, * User VMA. */ if (user_vma_start < user_vma_limit) { - (void) snprintf(alloc_name, sizeof(alloc_name), "gk20a_%s", - name); + (void) strcpy(alloc_name, "gk20a_"); + (void) strcat(alloc_name, name); err = nvgpu_allocator_init(g, &vm->user, vm, alloc_name, user_vma_start, @@ -485,8 +485,9 @@ int nvgpu_vm_do_init(struct mm_gk20a *mm, * User VMA for large pages when a split address range is used. */ if (user_lp_vma_start < user_lp_vma_limit) { - (void) snprintf(alloc_name, sizeof(alloc_name), "gk20a_%s_lp", - name); + (void) strcpy(alloc_name, "gk20a_"); + (void) strcat(alloc_name, name); + (void) strcat(alloc_name, "_lp"); err = nvgpu_allocator_init(g, &vm->user_lp, vm, alloc_name, user_lp_vma_start, @@ -504,7 +505,9 @@ int nvgpu_vm_do_init(struct mm_gk20a *mm, /* * Kernel VMA. Must always exist for an address space. */ - (void) snprintf(alloc_name, sizeof(alloc_name), "gk20a_%s-sys", name); + (void) strcpy(alloc_name, "gk20a_"); + (void) strcat(alloc_name, name); + (void) strcat(alloc_name, "-sys"); err = nvgpu_allocator_init(g, &vm->kernel, vm, alloc_name, kernel_vma_start,