mirror of
git://nv-tegra.nvidia.com/linux-nvgpu.git
synced 2025-12-24 02:22:34 +03:00
gpu: nvgpu: add UT coverage for sync unit
This patch adds full branch coverage for the functions nvgpu_channel_sync_create and nvgpu_channel_sync_destroy. Jira NVGPU-913 Change-Id: Iab9922ccd57873f0aab452805ea506b4b2601d5d Signed-off-by: Debarshi Dutta <ddutta@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/2254954 Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
This commit is contained in:
Debarshi Dutta
committed by
Alex Waterman
Alex Waterman
parent
d0bc8237e3
commit
25adc8d587
@@ -25,12 +25,15 @@
|
||||
#include <nvgpu/types.h>
|
||||
#include <nvgpu/gk20a.h>
|
||||
#include <nvgpu/hal_init.h>
|
||||
#include <nvgpu/dma.h>
|
||||
#include <nvgpu/posix/io.h>
|
||||
#include <os/posix/os_posix.h>
|
||||
#include <nvgpu/posix/posix-fault-injection.h>
|
||||
#include <nvgpu/posix/posix-nvhost.h>
|
||||
#include <nvgpu/channel.h>
|
||||
#include <nvgpu/channel_sync.h>
|
||||
|
||||
#include "../fifo/nvgpu-fifo.h"
|
||||
#include "../fifo/nvgpu-fifo-gv11b.h"
|
||||
#include "nvgpu-sync.h"
|
||||
|
||||
@@ -38,8 +41,75 @@
|
||||
NVGPU_GPU_ARCHITECTURE_SHIFT)
|
||||
#define NV_PMC_BOOT_0_IMPLEMENTATION_B 0xB
|
||||
|
||||
#define assert(cond) unit_assert(cond, goto done)
|
||||
|
||||
static struct nvgpu_channel *ch;
|
||||
|
||||
static int init_syncpt_mem(struct unit_module *m, struct gk20a *g)
|
||||
{
|
||||
u64 nr_pages;
|
||||
int err;
|
||||
if (!nvgpu_mem_is_valid(&g->syncpt_mem)) {
|
||||
nr_pages = U64(DIV_ROUND_UP(g->syncpt_unit_size,
|
||||
PAGE_SIZE));
|
||||
err = nvgpu_mem_create_from_phys(g, &g->syncpt_mem,
|
||||
g->syncpt_unit_base, nr_pages);
|
||||
if (err != 0) {
|
||||
nvgpu_err(g, "Failed to create syncpt mem");
|
||||
return err;
|
||||
}
|
||||
}
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
static int de_init_syncpt_mem(struct unit_module *m, struct gk20a *g)
|
||||
{
|
||||
if (nvgpu_mem_is_valid(&g->syncpt_mem))
|
||||
nvgpu_dma_free(g, &g->syncpt_mem);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
static int init_channel_vm(struct unit_module *m, struct nvgpu_channel *ch)
|
||||
{
|
||||
u64 low_hole, aperture_size;
|
||||
struct gk20a *g = ch->g;
|
||||
struct nvgpu_os_posix *p = nvgpu_os_posix_from_gk20a(g);
|
||||
struct mm_gk20a *mm = &g->mm;
|
||||
|
||||
p->mm_is_iommuable = true;
|
||||
/*
|
||||
* Initialize one VM space for system memory to be used throughout this
|
||||
* unit module.
|
||||
* Values below are similar to those used in nvgpu_init_system_vm()
|
||||
*/
|
||||
low_hole = SZ_4K * 16UL;
|
||||
aperture_size = GK20A_PMU_VA_SIZE;
|
||||
|
||||
mm->pmu.aperture_size = GK20A_PMU_VA_SIZE;
|
||||
mm->channel.user_size = NV_MM_DEFAULT_USER_SIZE -
|
||||
NV_MM_DEFAULT_KERNEL_SIZE;
|
||||
mm->channel.kernel_size = NV_MM_DEFAULT_KERNEL_SIZE;
|
||||
|
||||
mm->pmu.vm = nvgpu_vm_init(g,
|
||||
g->ops.mm.gmmu.get_default_big_page_size(),
|
||||
low_hole,
|
||||
aperture_size - low_hole,
|
||||
aperture_size,
|
||||
true,
|
||||
false,
|
||||
false,
|
||||
"system");
|
||||
if (mm->pmu.vm == NULL) {
|
||||
unit_return_fail(m, "nvgpu_vm_init failed\n");
|
||||
}
|
||||
|
||||
ch->vm = mm->pmu.vm;
|
||||
|
||||
return UNIT_SUCCESS;
|
||||
}
|
||||
|
||||
int test_sync_init(struct unit_module *m, struct gk20a *g, void *args)
|
||||
{
|
||||
int ret = 0;
|
||||
@@ -63,40 +133,286 @@ int test_sync_init(struct unit_module *m, struct gk20a *g, void *args)
|
||||
return -ENODEV;
|
||||
}
|
||||
|
||||
/*
|
||||
* Init g->nvhost_dev containing sync metadata
|
||||
*/
|
||||
ret = nvgpu_get_nvhost_dev(g);
|
||||
if (ret != 0) {
|
||||
unit_return_fail(m, "nvgpu_sync_early_init failed\n");
|
||||
}
|
||||
|
||||
/*
|
||||
* Alloc memory for g->syncpt_mem
|
||||
*/
|
||||
ret = init_syncpt_mem(m, g);
|
||||
if (ret != 0) {
|
||||
nvgpu_free_nvhost_dev(g);
|
||||
unit_return_fail(m, "sync mem allocation failure");
|
||||
}
|
||||
|
||||
/*
|
||||
* Alloc memory for channel
|
||||
*/
|
||||
ch = nvgpu_kzalloc(g, sizeof(struct nvgpu_channel));
|
||||
if (ch == NULL) {
|
||||
de_init_syncpt_mem(m, g);
|
||||
nvgpu_free_nvhost_dev(g);
|
||||
unit_return_fail(m, "sync channel creation failure");
|
||||
}
|
||||
|
||||
ch->g = g;
|
||||
|
||||
return UNIT_SUCCESS;
|
||||
}
|
||||
|
||||
int test_sync_create_sync(struct unit_module *m, struct gk20a *g, void *args)
|
||||
{
|
||||
struct nvgpu_channel_sync *sync = NULL;
|
||||
|
||||
sync = nvgpu_channel_sync_create(ch, true);
|
||||
|
||||
if (sync != NULL) {
|
||||
unit_return_fail(m, "expected failure in creating sync points");
|
||||
/*
|
||||
* Alloc and Init a VM for the channel
|
||||
*/
|
||||
ret = init_channel_vm(m, ch);
|
||||
if (ret != 0) {
|
||||
nvgpu_kfree(g, ch);
|
||||
de_init_syncpt_mem(m, g);
|
||||
nvgpu_free_nvhost_dev(g);
|
||||
unit_return_fail(m, "sync channel vm init failure");
|
||||
}
|
||||
|
||||
return UNIT_SUCCESS;
|
||||
}
|
||||
|
||||
#define F_SYNC_DESTROY_SET_SAFE 0
|
||||
#define F_SYNC_DESTROY_LAST 1
|
||||
|
||||
static const char *f_sync_destroy_syncpt[] = {
|
||||
"sync_destroy_set_safe",
|
||||
"sync_destroy",
|
||||
};
|
||||
|
||||
int test_sync_create_destroy_sync(struct unit_module *m, struct gk20a *g, void *args)
|
||||
{
|
||||
struct nvgpu_channel_sync *sync = NULL;
|
||||
u32 branches;
|
||||
bool set_safe_state = true;
|
||||
|
||||
u32 syncpt_value = 0U;
|
||||
int ret = UNIT_FAIL;
|
||||
|
||||
for (branches = 0U; branches <= F_SYNC_DESTROY_LAST; branches++) {
|
||||
|
||||
sync = nvgpu_channel_sync_create(ch, true);
|
||||
if (sync == NULL) {
|
||||
unit_return_fail(m, "unexpected failure in creating sync points");
|
||||
}
|
||||
|
||||
syncpt_value = g->nvhost_dev->syncpt_value;
|
||||
|
||||
unit_info(m, "Syncpt ID: %u, Syncpt Value: %u\n",
|
||||
g->nvhost_dev->syncpt_id, syncpt_value);
|
||||
|
||||
assert((g->nvhost_dev->syncpt_id > 0U) &&
|
||||
(g->nvhost_dev->syncpt_id <= NUM_HW_PTS));
|
||||
|
||||
assert(syncpt_value < (UINT_MAX - SYNCPT_SAFE_STATE_INCR));
|
||||
|
||||
if (branches == F_SYNC_DESTROY_SET_SAFE) {
|
||||
set_safe_state = false;
|
||||
}
|
||||
|
||||
unit_info(m, "%s branch: %s\n", __func__, f_sync_destroy_syncpt[branches]);
|
||||
|
||||
nvgpu_channel_sync_destroy(sync, set_safe_state);
|
||||
|
||||
sync = NULL;
|
||||
}
|
||||
|
||||
ret = UNIT_SUCCESS;
|
||||
|
||||
done:
|
||||
if (sync != NULL)
|
||||
nvgpu_channel_sync_destroy(sync, set_safe_state);
|
||||
|
||||
if (nvgpu_mem_is_valid(&g->syncpt_mem) &&
|
||||
ch->vm->syncpt_ro_map_gpu_va != 0ULL) {
|
||||
nvgpu_gmmu_unmap(ch->vm, &g->syncpt_mem,
|
||||
ch->vm->syncpt_ro_map_gpu_va);
|
||||
ch->vm->syncpt_ro_map_gpu_va = 0ULL;
|
||||
}
|
||||
|
||||
return ret;
|
||||
}
|
||||
|
||||
int test_sync_set_safe_state(struct unit_module *m, struct gk20a *g, void *args)
|
||||
{
|
||||
struct nvgpu_channel_sync *sync = NULL;
|
||||
|
||||
u32 syncpt_value, syncpt_id;
|
||||
u32 syncpt_safe_state_val;
|
||||
|
||||
int ret = UNIT_FAIL;
|
||||
|
||||
sync = nvgpu_channel_sync_create(ch, true);
|
||||
if (sync == NULL) {
|
||||
unit_return_fail(m, "unexpected failure in creating sync points");
|
||||
}
|
||||
|
||||
syncpt_id = g->nvhost_dev->syncpt_id;
|
||||
syncpt_value = g->nvhost_dev->syncpt_value;
|
||||
|
||||
unit_info(m, "Syncpt ID: %u, Syncpt Value: %u\n",
|
||||
syncpt_id, syncpt_value);
|
||||
|
||||
assert((syncpt_id > 0U) && (syncpt_id <= NUM_HW_PTS));
|
||||
|
||||
assert(syncpt_value < (UINT_MAX - SYNCPT_SAFE_STATE_INCR));
|
||||
|
||||
nvgpu_channel_sync_set_safe_state(sync);
|
||||
|
||||
syncpt_safe_state_val = g->nvhost_dev->syncpt_value;
|
||||
|
||||
if ((syncpt_safe_state_val - syncpt_value) != SYNCPT_SAFE_STATE_INCR) {
|
||||
unit_return_fail(m, "unexpected increment value for safe state");
|
||||
}
|
||||
|
||||
nvgpu_channel_sync_destroy(sync, false);
|
||||
|
||||
sync = NULL;
|
||||
|
||||
ret = UNIT_SUCCESS;
|
||||
|
||||
done:
|
||||
if (sync != NULL)
|
||||
nvgpu_channel_sync_destroy(sync, false);
|
||||
|
||||
return ret;
|
||||
}
|
||||
|
||||
#define F_SYNC_SYNCPT_ALLOC_FAILED 0
|
||||
#define F_SYNC_USER_MANAGED 1
|
||||
#define F_SYNC_NVHOST_CLIENT_MANAGED_FAIL 2
|
||||
#define F_SYNC_RO_MAP_GPU_VA_MAP_FAIL 3
|
||||
#define F_SYNC_MEM_CREATE_PHYS_FAIL 4
|
||||
#define F_SYNC_BUF_MAP_FAIL 5
|
||||
#define F_SYNC_FAIL_LAST 6
|
||||
|
||||
static const char *f_syncpt_open[] = {
|
||||
"syncpt_alloc_failed",
|
||||
"syncpt_user_managed_false",
|
||||
"syncpt_get_client_managed_fail",
|
||||
"syncpt_ro_map_gpu_va_fail",
|
||||
"syncpt_create_phys_mem_fail",
|
||||
"syncpt_buf_map_fail",
|
||||
};
|
||||
|
||||
static void clear_test_params(struct gk20a *g, bool *user_managed,
|
||||
bool *fault_injection_enabled, u32 branch,
|
||||
struct nvgpu_posix_fault_inj *kmem_fi)
|
||||
{
|
||||
if (!(*user_managed)) {
|
||||
*user_managed = true;
|
||||
}
|
||||
|
||||
if (ch->vm->guest_managed) {
|
||||
ch->vm->guest_managed = false;
|
||||
}
|
||||
|
||||
if (*fault_injection_enabled) {
|
||||
nvgpu_posix_enable_fault_injection(kmem_fi, false, 0);
|
||||
*fault_injection_enabled = false;
|
||||
}
|
||||
|
||||
if (branch == F_SYNC_NVHOST_CLIENT_MANAGED_FAIL) {
|
||||
g->nvhost_dev->syncpt_id = 1U;
|
||||
}
|
||||
|
||||
if (ch->vm->syncpt_ro_map_gpu_va) {
|
||||
ch->vm->syncpt_ro_map_gpu_va = 0ULL;
|
||||
}
|
||||
}
|
||||
|
||||
int test_sync_create_fail(struct unit_module *m, struct gk20a *g, void *args)
|
||||
{
|
||||
struct nvgpu_channel_sync *sync = NULL;
|
||||
struct nvgpu_posix_fault_inj *kmem_fi;
|
||||
u32 branches;
|
||||
bool user_managed = true;
|
||||
bool fault_injection_enabled = false;
|
||||
int ret = UNIT_FAIL;
|
||||
|
||||
kmem_fi = nvgpu_kmem_get_fault_injection();
|
||||
|
||||
ch->vm->syncpt_ro_map_gpu_va = 0U;
|
||||
|
||||
for (branches = 0U; branches < F_SYNC_FAIL_LAST; branches++) {
|
||||
|
||||
u32 syncpt_id, syncpt_value;
|
||||
|
||||
if (branches == F_SYNC_SYNCPT_ALLOC_FAILED) {
|
||||
/* fail first kzalloc call */
|
||||
nvgpu_posix_enable_fault_injection(kmem_fi, true, 0);
|
||||
fault_injection_enabled = true;
|
||||
} else if (branches == F_SYNC_USER_MANAGED) {
|
||||
user_managed = false;
|
||||
} else if (branches == F_SYNC_NVHOST_CLIENT_MANAGED_FAIL) {
|
||||
g->nvhost_dev->syncpt_id = 20U; /* arbitary id */
|
||||
} else if (branches == F_SYNC_RO_MAP_GPU_VA_MAP_FAIL) {
|
||||
/* fail Read-Only nvgpu_gmmu_map of g->syncpt_mem */
|
||||
ch->vm->guest_managed = true;
|
||||
} else if (branches == F_SYNC_MEM_CREATE_PHYS_FAIL) {
|
||||
/*
|
||||
* bypass map of g->syncpt_mem and fail at
|
||||
* nvgpu_mem_create_from_phys after first kzalloc.
|
||||
*/
|
||||
ch->vm->syncpt_ro_map_gpu_va = 0x1000ULL;
|
||||
nvgpu_posix_enable_fault_injection(kmem_fi, true, 1);
|
||||
fault_injection_enabled = true;
|
||||
} else if (branches == F_SYNC_BUF_MAP_FAIL) {
|
||||
/*
|
||||
* bypass map of g->syncpt_mem and fail at
|
||||
* nvgpu_gmmu_map after first kzalloc and then two
|
||||
* consequtive calls to kmalloc
|
||||
*/
|
||||
ch->vm->syncpt_ro_map_gpu_va = 1ULL;
|
||||
nvgpu_posix_enable_fault_injection(kmem_fi, true, 3);
|
||||
fault_injection_enabled = true;
|
||||
} else {
|
||||
continue;
|
||||
}
|
||||
|
||||
unit_info(m, "%s branch: %s\n", __func__, f_syncpt_open[branches]);
|
||||
|
||||
sync = nvgpu_channel_sync_create(ch, user_managed);
|
||||
if (sync != NULL) {
|
||||
nvgpu_channel_sync_destroy(sync, true);
|
||||
unit_return_fail(m, "expected failure in creating sync points");
|
||||
}
|
||||
|
||||
syncpt_id = g->nvhost_dev->syncpt_id;
|
||||
syncpt_value = g->nvhost_dev->syncpt_value;
|
||||
|
||||
assert(syncpt_id == 0U);
|
||||
assert(syncpt_value == 0U);
|
||||
|
||||
clear_test_params(g, &user_managed, &fault_injection_enabled,
|
||||
branches, kmem_fi);
|
||||
|
||||
}
|
||||
|
||||
ret = UNIT_SUCCESS;
|
||||
|
||||
done:
|
||||
clear_test_params(g, &user_managed, &fault_injection_enabled,
|
||||
0, kmem_fi);
|
||||
|
||||
return ret;
|
||||
}
|
||||
|
||||
int test_sync_deinit(struct unit_module *m, struct gk20a *g, void *args)
|
||||
{
|
||||
|
||||
nvgpu_vm_put(g->mm.pmu.vm);
|
||||
|
||||
if (ch != NULL) {
|
||||
nvgpu_kfree(g, ch);
|
||||
}
|
||||
|
||||
de_init_syncpt_mem(m, g);
|
||||
|
||||
if (g->nvhost_dev == NULL) {
|
||||
unit_return_fail(m ,"no valid nvhost device exists\n");
|
||||
}
|
||||
@@ -110,8 +426,10 @@ int test_sync_deinit(struct unit_module *m, struct gk20a *g, void *args)
|
||||
|
||||
struct unit_module_test nvgpu_sync_tests[] = {
|
||||
UNIT_TEST(sync_init, test_sync_init, NULL, 0),
|
||||
UNIT_TEST(sync_deinit, test_sync_create_sync, NULL, 0),
|
||||
UNIT_TEST(sync_create_destroy, test_sync_create_destroy_sync, NULL, 0),
|
||||
UNIT_TEST(sync_set_safe_state, test_sync_set_safe_state, NULL, 0),
|
||||
UNIT_TEST(sync_fail, test_sync_create_fail, NULL, 0),
|
||||
UNIT_TEST(sync_deinit, test_sync_deinit, NULL, 0),
|
||||
};
|
||||
|
||||
UNIT_MODULE(nvgpu-sync, nvgpu_sync_tests, UNIT_PRIO_NVGPU_TEST);
|
||||
UNIT_MODULE(nvgpu-sync, nvgpu_sync_tests, UNIT_PRIO_NVGPU_TEST);
|
||||
|
||||
Reference in New Issue
Block a user