nv-tegra-mirror/linux-nvgpu
1
0
Fork 0
mirror of git://nv-tegra.nvidia.com/linux-nvgpu.git synced 2025-12-22 17:36:20 +03:00
Code Issues Packages Projects Releases Wiki Activity

nvgpu: reorder the check for same mask value

Browse Source 
After the board boots up, we have a specific set of settings for
each power mode which contains, fbp, tpc mask values, cpu, gpu
frequencies etc. So, we need to make sure to provide all the setting
values for each mode so that those will be applied correctly.
So, the fbp, tpc, gpc mask could be same in different power modes
and since the golden image context check which comes before is
returning -ENODEV, the nvpmodel service fails to set the power mode.

Thus, we need to compare whether the fbp and gpc mask values are same
before we check for the golden image context.

Bug 3581634

Change-Id: I3fb1398d47cd37bf49ad70cf80b057d4b80dec04
Signed-off-by: Ninad Malwade <nmalwade@nvidia.com>
(cherry picked from commit a27e202402)
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvgpu/+/2688116
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
This commit is contained in:
Ninad Malwade
2022-03-24 16:57:38 +08:00
committed by mobile promotions
parent ac879458ca
commit 2710721e63
1 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
drivers/gpu/nvgpu/os/linux/sysfs.c
View File

@@ -887,6 +887,11 @@ static ssize_t gpc_pg_mask_store(struct device *dev,
return -EINVAL; return -EINVAL;
} }
if (val == g->gpc_pg_mask) {
nvgpu_info(g, "no value change, same mask already set");
goto exit;
}
if (g->gr != NULL) { if (g->gr != NULL) {
gr_golden_image = nvgpu_gr_get_golden_image_ptr(g); gr_golden_image = nvgpu_gr_get_golden_image_ptr(g);
} }
@@ -899,11 +904,6 @@ static ssize_t gpc_pg_mask_store(struct device *dev,
return -ENODEV; return -ENODEV;
} }
if (val == g->gpc_pg_mask) {
nvgpu_info(g, "no value change, same mask already set");
goto exit;
}
if (platform->set_gpc_pg_mask != NULL) { if (platform->set_gpc_pg_mask != NULL) {
err = platform->set_gpc_pg_mask(dev, val); err = platform->set_gpc_pg_mask(dev, val);
if (err != 0) { if (err != 0) {
@@ -967,6 +967,11 @@ static ssize_t fbp_pg_mask_store(struct device *dev,
return -EINVAL; return -EINVAL;
} }
if (val == g->fbp_pg_mask) {
nvgpu_info(g, "no value change, same mask already set");
goto exit;
}
if (g->gr != NULL) { if (g->gr != NULL) {
gr_golden_image = nvgpu_gr_get_golden_image_ptr(g); gr_golden_image = nvgpu_gr_get_golden_image_ptr(g);
} }
@@ -979,11 +984,6 @@ static ssize_t fbp_pg_mask_store(struct device *dev,
return -ENODEV; return -ENODEV;
} }
if (val == g->fbp_pg_mask) {
nvgpu_info(g, "no value change, same mask already set");
goto exit;
}
if (platform->set_fbp_pg_mask != NULL) { if (platform->set_fbp_pg_mask != NULL) {
err = platform->set_fbp_pg_mask(dev, val); err = platform->set_fbp_pg_mask(dev, val);
if (err != 0) { if (err != 0) {