From 2c7afa96b95e007a0658878017efb9fd44677a1f Mon Sep 17 00:00:00 2001 From: Seshendra Gadagottu Date: Fri, 18 Jun 2021 16:38:33 -0700 Subject: [PATCH] gpu: nvgpu: fix DVR issues in common.fb unit Update documentation to fix issues related with spellings and format. JIRA NVGPU-6607 Change-Id: Id70bf4c29b23fa4880ae679b04170c2a82c2775c Signed-off-by: Seshendra Gadagottu Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvgpu/+/2547490 Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvgpu/+/2560281 Reviewed-by: svcacv Reviewed-by: svc_kernel_abi Reviewed-by: Seema Khowala Reviewed-by: mobile promotions GVS: Gerrit_Virtual_Submit Tested-by: mobile promotions --- drivers/gpu/nvgpu/include/nvgpu/gops/fb.h | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/nvgpu/include/nvgpu/gops/fb.h b/drivers/gpu/nvgpu/include/nvgpu/gops/fb.h index 49695a963..1a36438ec 100644 --- a/drivers/gpu/nvgpu/include/nvgpu/gops/fb.h +++ b/drivers/gpu/nvgpu/include/nvgpu/gops/fb.h @@ -223,11 +223,16 @@ struct gops_fb { void (*init_hw)(struct gk20a *g); /** - * @brief Intitilizes controls for GMMU state + * @brief Intitializes controls for GMMU state. * * @param g [in] Pointer to GPU driver struct. * * This function initializes chip specific fb state. + * This function sets platform atomic capability mode to the + * following configuration: + * - NV_PFB_PRI_MMU_CTRL_ATOMIC_CAPABILITY_MODE to RMW MODE + * - NV_PFB_PRI_MMU_CTRL_ATOMIC_CAPABILITY_SYS_NCOH_MODE to L2 + * - NV_PFB_HSHUB_NUM_ACTIVE_LTCS_HUB_SYS_ATOMIC_MODE to USE_RMW */ void (*init_fs_state)(struct gk20a *g); @@ -289,7 +294,7 @@ struct gops_fb { * memory controller. VPR info has following data: * - addr_lo displays the lower address of the VPR * - addr_hi displays the upper address of the VPR. - * - cya_low and cya_hi displays CYA bits the control the + * - cya_low and cya_hi displays CYA bits that controls the * trust level of each client. */ void (*dump_vpr_info)(struct gk20a *g); @@ -388,7 +393,7 @@ struct gops_fb { * @param state [in] NVGPU_MMU_FAULT_BUF_ENABLED or * NVGPU_MMU_FAULT_BUF_DISABLED * - * This function set-up mmu fault buffer state. + * This function sets up mmu fault buffer state. * NVGPU_MMU_FAULT_BUF_ENABLED : set the actual size of fault buffer. * NVGPU_MMU_FAULT_BUF_DISABLED : Clears fault buffer size. */