From 310471bf77ea1974cdf694baf8f315ebc9f4213d Mon Sep 17 00:00:00 2001 From: Thomas Fleury Date: Fri, 10 May 2019 11:29:29 -0700 Subject: [PATCH] gpu: nvgpu: fix MISRA 17.7 violation in nvgpu.common.mm.mm Below MISRA 17.7 violation is reported in nvgpu.common.mm.mm ${TEGRA_TOP}/kernel/nvgpu/drivers/gpu/nvgpu/common/mm/mm.c:645: misra_c_2012_rule_17_7: The return value of a non-void function "*g->ops.bus.bar1_bind" is unused. Fix this by checking return value and returning an error in case of failure. Jira NVGPU-3331 Change-Id: Iab43d630163af782d3cc87989a64062516a4cd92 Signed-off-by: Thomas Fleury Reviewed-on: https://git-master.nvidia.com/r/2116706 GVS: Gerrit_Virtual_Submit Reviewed-by: Vinod Gopalakrishnakurup Reviewed-by: mobile promotions Tested-by: mobile promotions --- drivers/gpu/nvgpu/common/mm/mm.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/nvgpu/common/mm/mm.c b/drivers/gpu/nvgpu/common/mm/mm.c index 8497e879b..dc6bc32c7 100644 --- a/drivers/gpu/nvgpu/common/mm/mm.c +++ b/drivers/gpu/nvgpu/common/mm/mm.c @@ -642,7 +642,10 @@ int nvgpu_mm_setup_hw(struct gk20a *g) g->ops.fb.init_hw(g); if (g->ops.bus.bar1_bind != NULL) { - g->ops.bus.bar1_bind(g, &mm->bar1.inst_block); + err = g->ops.bus.bar1_bind(g, &mm->bar1.inst_block); + if (err != 0) { + return err; + } } if (g->ops.bus.bar2_bind != NULL) {