From 38819216bd304bc81cb985e42a9384afd3ee3053 Mon Sep 17 00:00:00 2001 From: Nicolas Benech Date: Thu, 17 Jan 2019 17:30:51 -0500 Subject: [PATCH] gpu: nvgpu: dbg_..._stop_trigger() to return void nvgpu_dbg_gpu_clear_broadcast_stop_trigger was always returning 0. This patch changes it to return void, thus fixing a number of MISRA violations. JIRA NVGPU-677 Change-Id: Ib9cbce6e9ed5ecf6ed0fdab714adbb0ecff4ec5b Signed-off-by: Nicolas Benech Reviewed-on: https://git-master.nvidia.com/r/1998806 Reviewed-by: svc-misra-checker Reviewed-by: svc-mobile-coverity Reviewed-by: svc-mobile-misra Reviewed-by: Terje Bergstrom GVS: Gerrit_Virtual_Submit Reviewed-by: Alex Waterman Reviewed-by: mobile promotions Tested-by: mobile promotions --- drivers/gpu/nvgpu/common/debugger.c | 4 +--- drivers/gpu/nvgpu/include/nvgpu/debugger.h | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/nvgpu/common/debugger.c b/drivers/gpu/nvgpu/common/debugger.c index d7b622928..867fcc697 100644 --- a/drivers/gpu/nvgpu/common/debugger.c +++ b/drivers/gpu/nvgpu/common/debugger.c @@ -121,7 +121,7 @@ bool nvgpu_dbg_gpu_broadcast_stop_trigger(struct channel_gk20a *ch) return broadcast; } -int nvgpu_dbg_gpu_clear_broadcast_stop_trigger(struct channel_gk20a *ch) +void nvgpu_dbg_gpu_clear_broadcast_stop_trigger(struct channel_gk20a *ch) { struct dbg_session_data *session_data; struct dbg_session_gk20a *dbg_s; @@ -143,8 +143,6 @@ int nvgpu_dbg_gpu_clear_broadcast_stop_trigger(struct channel_gk20a *ch) } nvgpu_mutex_release(&ch->dbg_s_lock); - - return 0; } u32 nvgpu_set_powergate_locked(struct dbg_session_gk20a *dbg_s, diff --git a/drivers/gpu/nvgpu/include/nvgpu/debugger.h b/drivers/gpu/nvgpu/include/nvgpu/debugger.h index 8cf02c622..04921b676 100644 --- a/drivers/gpu/nvgpu/include/nvgpu/debugger.h +++ b/drivers/gpu/nvgpu/include/nvgpu/debugger.h @@ -118,7 +118,7 @@ dbg_profiler_object_data_from_prof_obj_entry(struct nvgpu_list_node *node) void nvgpu_dbg_gpu_post_events(struct channel_gk20a *ch); bool nvgpu_dbg_gpu_broadcast_stop_trigger(struct channel_gk20a *ch); -int nvgpu_dbg_gpu_clear_broadcast_stop_trigger(struct channel_gk20a *ch); +void nvgpu_dbg_gpu_clear_broadcast_stop_trigger(struct channel_gk20a *ch); int nvgpu_dbg_set_powergate(struct dbg_session_gk20a *dbg_s, bool disable_powergate); bool nvgpu_check_and_set_global_reservation(