From 4ec683975a515da4735b114a29870492cd2e8f89 Mon Sep 17 00:00:00 2001 From: Richard Zhao Date: Wed, 8 Mar 2023 21:04:30 -0800 Subject: [PATCH] gpu: nvgpu: obj_ctx: fix possible mem leak When generate golden image, subctx_mask memory was not freed on fail. It was detected by code coverity checker. Bug 3952896 Change-Id: Iae0c78b11003980c6b09ec0e72bebfda0a244b17 Signed-off-by: Richard Zhao Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvgpu/+/2868150 Tested-by: mobile promotions Reviewed-by: mobile promotions --- drivers/gpu/nvgpu/common/gr/obj_ctx.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/nvgpu/common/gr/obj_ctx.c b/drivers/gpu/nvgpu/common/gr/obj_ctx.c index 152252270..e6d570130 100644 --- a/drivers/gpu/nvgpu/common/gr/obj_ctx.c +++ b/drivers/gpu/nvgpu/common/gr/obj_ctx.c @@ -1023,9 +1023,8 @@ static int nvgpu_gr_golden_ctx_prepare_inst_block( if (subctx_pdb_map == NULL || subctx_mask == NULL) { err = -ENOMEM; - if (subctx_pdb_map != NULL) { - nvgpu_kfree(g, subctx_pdb_map); - } + nvgpu_kfree(g, subctx_mask); + nvgpu_kfree(g, subctx_pdb_map); nvgpu_free_inst_block(g, inst_block); return err; }