nv-tegra-mirror/linux-nvgpu
1
0
Fork 0
mirror of git://nv-tegra.nvidia.com/linux-nvgpu.git synced 2025-12-22 09:12:24 +03:00
Code Issues Packages Projects Releases Wiki Activity

gpu: nvgpu: mc: address code inspection gaps

Browse Source 
Address following issues uncovered during inspection:
1. Remove the doxygen comment from nvgpu_wait_for_deferred_interrupts
   definition.
2. Use NVGPU_MC_INTR_STALLING instead of hardcoding the index.
3. Define doxygen groups NVGPU_MC_UNIT_ENUMS,
   NVGPU_MC_INTR_TYPE_DEFINES, NVGPU_MC_INTR_UNIT_DEFINES and
   NVGPU_MC_INTR_ENABLE_DEFINES.
4. Update the doxygen comments.
5. Fix the cleanup, typo in the description of the test
   test_wait_for_deferred_interrupts.

JIRA NVGPU-4795

Change-Id: Ifc6756832aabf9dd42ee174eb1373495e6d38c86
Signed-off-by: Sagar Kamble <skamble@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvgpu/+/2287627
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
This commit is contained in:
Sagar Kamble
2020-01-30 17:20:59 +05:30
committed by Alex Waterman
parent d794ec926c
commit 57f3968cb9
7 changed files with 63 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
userspace/units/mc/nvgpu-mc.c
View File

@@ -784,6 +784,9 @@ int test_wait_for_deferred_interrupts(struct unit_module *m, struct gk20a *g,
nvgpu_atomic_set(&g->mc.sw_irq_nonstall_pending, 1);
nvgpu_wait_for_deferred_interrupts(g);
/* disable the fault injection */
nvgpu_posix_enable_fault_injection(cond_fi, false, 0);
return UNIT_SUCCESS;
}

5
userspace/units/mc/nvgpu-mc.h
View File

@@ -332,7 +332,7 @@ int test_reset_mask(struct unit_module *m, struct gk20a *g, void *args);
/**
* Test specification for: test_wait_for_deferred_interrupts
*
* Description: Validate functionality of HAL to get reset mask for a unit.
* Description: Validate functionality of waiting for deferred interrupts.
*
* Test Type: Feature
*
@@ -351,6 +351,7 @@ int test_reset_mask(struct unit_module *m, struct gk20a *g, void *args);
* - Call the API.
* - Set the irq count states in the gk20a struct to simulate pending non-stall
* interrupts.
* - Disable cond fault injection.
*
* Output: Returns PASS if expected result is met, FAIL otherwise.
*/
@@ -361,4 +362,4 @@ int test_wait_for_deferred_interrupts(struct unit_module *m, struct gk20a *g,
* @}
*/
#endif /* UNIT_NVGPU_CE_H */
#endif /* UNIT_NVGPU_CE_H */