nv-tegra-mirror/linux-nvgpu
1
0
Fork 0
mirror of git://nv-tegra.nvidia.com/linux-nvgpu.git synced 2025-12-22 17:36:20 +03:00
Code Issues Packages Projects Releases Wiki Activity

gpu: nvgpu: use appropriate permissions for debugfs entries

Browse Source 
SW Profiler's debugfs entry "enable" has both RW permissions set
however the corresponding read operation is set to NULL.

Similarly, the other entries i.e. "percentiles", "raw_entries" and
"basic_stats" only have a read operation defined and write is set to
NULL.

To enable correct permissions, set permission for "enable" to "W"
and set permissions for others as "R" only.

Bug 200747304

Change-Id: I296a0ff08a871f752988c9b0a671c080695d5eab
Signed-off-by: Debarshi Dutta <ddutta@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvgpu/+/2566322
(cherry picked from commit 8542dd388da536ee693610acd0bb3a679ff52881)
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvgpu/+/2628035
Tested-by: Jonathan Hunter <jonathanh@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
Reviewed-by: Jonathan Hunter <jonathanh@nvidia.com>
Reviewed-by: Alex Waterman <alexw@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
GVS: Gerrit_Virtual_Submit
This commit is contained in:
Debarshi Dutta
2021-07-28 11:13:10 +05:30
committed by mobile promotions
parent cce1d7ad84
commit 5d42343cbf
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/gpu/nvgpu/os/linux/swprofile_debugfs.c
View File

@@ -1,5 +1,5 @@
/*
* Copyright (c) 2020, NVIDIA CORPORATION. All rights reserved.
* Copyright (c) 2020-2021, NVIDIA CORPORATION. All rights reserved.
*
* This program is free software; you can redistribute it and/or modify it
* under the terms and conditions of the GNU General Public License,
@@ -130,15 +130,15 @@ void nvgpu_debugfs_swprofile_init(struct gk20a *g,
if (IS_ERR_OR_NULL(swprofile_root))
return;
debugfs_create_file("enable", 0600, swprofile_root, p,
debugfs_create_file("enable", 0200, swprofile_root, p,
&nvgpu_debugfs_swprofile_enable_debugfs_fops);
debugfs_create_file("percentiles", 0600, swprofile_root, p,
debugfs_create_file("percentiles", 0400, swprofile_root, p,
&nvgpu_debugfs_swprofile_stats_debugfs_fops);
debugfs_create_file("raw_data", 0600, swprofile_root, p,
debugfs_create_file("raw_data", 0400, swprofile_root, p,
&nvgpu_debugfs_swprofile_raw_data_debugfs_fops);
debugfs_create_file("basic_stats", 0600, swprofile_root, p,
debugfs_create_file("basic_stats", 0400, swprofile_root, p,
&nvgpu_debugfs_swprofile_basic_stats_debugfs_fops);
}