From 62c3b658effe1bad97329a6d3dcb2eff2a2d2d4d Mon Sep 17 00:00:00 2001 From: Seshendra Gadagottu Date: Fri, 26 Apr 2019 13:04:16 -0700 Subject: [PATCH] gpu: nvgpu: fix MISRA 17.7 rule in gr falcon Added return value error check for following function calls: nvgpu_gr_falcon_copy_ctxsw_ucode_segments JIRA NVGPU-3226 Change-Id: I52b930cc33414a93407b6ab60189148e93d8fcea Signed-off-by: Seshendra Gadagottu Reviewed-on: https://git-master.nvidia.com/r/2107662 GVS: Gerrit_Virtual_Submit Reviewed-by: Alex Waterman Reviewed-by: mobile promotions Tested-by: mobile promotions --- drivers/gpu/nvgpu/common/gr/gr_falcon.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/nvgpu/common/gr/gr_falcon.c b/drivers/gpu/nvgpu/common/gr/gr_falcon.c index 46cc53b46..49a96bdb1 100644 --- a/drivers/gpu/nvgpu/common/gr/gr_falcon.c +++ b/drivers/gpu/nvgpu/common/gr/gr_falcon.c @@ -326,20 +326,28 @@ int nvgpu_gr_falcon_init_ctxsw_ucode(struct gk20a *g, goto clean_up; } - nvgpu_gr_falcon_copy_ctxsw_ucode_segments(g, &ucode_info->surface_desc, + err = nvgpu_gr_falcon_copy_ctxsw_ucode_segments(g, + &ucode_info->surface_desc, &ucode_info->fecs, fecs_boot_image, nvgpu_netlist_get_fecs_inst_list(g), nvgpu_netlist_get_fecs_data_list(g)); + if (err != 0) { + goto clean_up; + } nvgpu_release_firmware(g, fecs_fw); fecs_fw = NULL; - nvgpu_gr_falcon_copy_ctxsw_ucode_segments(g, &ucode_info->surface_desc, + err = nvgpu_gr_falcon_copy_ctxsw_ucode_segments(g, + &ucode_info->surface_desc, &ucode_info->gpccs, gpccs_boot_image, nvgpu_netlist_get_gpccs_inst_list(g), nvgpu_netlist_get_gpccs_data_list(g)); + if (err != 0) { + goto clean_up; + } nvgpu_release_firmware(g, gpccs_fw); gpccs_fw = NULL;