From 684bc1c8cb64c2d007746bcc1c6b834e53a837a2 Mon Sep 17 00:00:00 2001 From: mkumbar Date: Fri, 29 Apr 2022 19:11:37 +0530 Subject: [PATCH] gpu: nvgpu: falcon debug unit update - Don't print error if debug display buffer is empty. Bug 3623500 Bug 3418561 Bug 3659996 Change-Id: I066999fb0f7d41d491c3b01df2b976fcfa833ebf Signed-off-by: mkumbar Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvgpu/+/2704967 Reviewed-by: svcacv Reviewed-by: Vijayakumar Subbu GVS: Gerrit_Virtual_Submit (cherry picked from commit 162d7ec32dace69800aee3e4cdb7e36aeddcb21f) Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvgpu/+/2722384 --- drivers/gpu/nvgpu/common/falcon/falcon_debug.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/nvgpu/common/falcon/falcon_debug.c b/drivers/gpu/nvgpu/common/falcon/falcon_debug.c index 44c3fc8ba..3e4f3abd4 100644 --- a/drivers/gpu/nvgpu/common/falcon/falcon_debug.c +++ b/drivers/gpu/nvgpu/common/falcon/falcon_debug.c @@ -197,7 +197,7 @@ static int falcon_update_debug_buffer_from_dmem(struct nvgpu_falcon *flcn, } if (first_read_size == 0 && second_read_size == 0) { - nvgpu_err(g, "Debug buffer empty, can't read any data!"); + nvgpu_falcon_dbg(g, "Debug buffer empty, can't read any data!"); return -EINVAL; } @@ -300,8 +300,9 @@ int nvgpu_falcon_dbg_buf_display(struct nvgpu_falcon *flcn) } if (falcon_update_debug_buffer_from_dmem(flcn, write_offset) != 0) { - nvgpu_err(g, "Failed to fetch debug buffer contents"); - return -EINVAL; + nvgpu_falcon_dbg(g, "Failed to fetch debug buffer contents"); + // Return error once Bug 3623500 issue is fixed + return 0; } /* Buffer is empty when read_offset == write_offset */