From 69f990623b8ba482057b5bde91f9cbb2364ddec4 Mon Sep 17 00:00:00 2001 From: Sagar Kamble Date: Thu, 19 Sep 2019 16:19:44 +0530 Subject: [PATCH] gpu: nvgpu: unit: fix falcon dmemc read logic Falcon DMEMC register read returns the bytes copied to DMEM. There was a mistake in calculating the bytes and setting access->value properly in falcon utf register read function. Fix it. JIRA NVGPU-2220 Change-Id: If6ba03f734e27d8d0d027f873b56330c17f7aa0b Signed-off-by: Sagar Kamble Reviewed-on: https://git-master.nvidia.com/r/2201515 Reviewed-by: svc-mobile-coverity Reviewed-by: svc-mobile-misra GVS: Gerrit_Virtual_Submit Reviewed-by: Divya Singhatwaria Reviewed-by: Vaibhav Kachore Reviewed-by: mobile promotions Tested-by: mobile promotions --- userspace/units/falcon/falcon_utf.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/userspace/units/falcon/falcon_utf.c b/userspace/units/falcon/falcon_utf.c index 3fcd90e1b..9d52beb4b 100644 --- a/userspace/units/falcon/falcon_utf.c +++ b/userspace/units/falcon/falcon_utf.c @@ -122,8 +122,7 @@ void nvgpu_utf_falcon_readl_access_reg_fn(struct gk20a *g, ctrl_r = nvgpu_posix_io_readl_reg_space(g, flcn_base + falcon_falcon_dmemc_r(0)); - offset = access->value & addr_mask; - access->value = offset * 4U; + access->value = ctrl_r & addr_mask; } else { access->value = nvgpu_posix_io_readl_reg_space(g, access->addr); }