nv-tegra-mirror/linux-nvgpu
1
0
Fork 0
mirror of git://nv-tegra.nvidia.com/linux-nvgpu.git synced 2025-12-22 17:36:20 +03:00
Code Issues Packages Projects Releases Wiki Activity

gpu: nvgpu: fix -EINVAL retval in ioctls

Browse Source 
Proper error number for invalid request number is EINVAL instead of
EFAULT, so change it in ioctl calls.

Change-Id: I8fddd34e012700550e9e30fe17ba7152b3a0417b
Signed-off-by: Konsta Holtta <kholtta@nvidia.com>
Reviewed-on: http://git-master/r/542563
Reviewed-by: Automatic_Commit_Validation_User
GVS: Gerrit_Virtual_Submit
Reviewed-by: Terje Bergstrom <tbergstrom@nvidia.com>
This commit is contained in:
Konsta Holtta
2014-09-29 10:37:33 +03:00
committed by Dan Willemsen
parent 435cf045d7
commit 6b85e32d6c
5 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/gpu/nvgpu/gk20a/as_gk20a.c
View File

@@ -219,7 +219,7 @@ long gk20a_as_dev_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
if ((_IOC_TYPE(cmd) != NVHOST_AS_IOCTL_MAGIC) || if ((_IOC_TYPE(cmd) != NVHOST_AS_IOCTL_MAGIC) ||
(_IOC_NR(cmd) == 0) || (_IOC_NR(cmd) == 0) ||
(_IOC_NR(cmd) > NVHOST_AS_IOCTL_LAST)) (_IOC_NR(cmd) > NVHOST_AS_IOCTL_LAST))
return -EFAULT; return -EINVAL;
BUG_ON(_IOC_SIZE(cmd) > NVHOST_AS_IOCTL_MAX_ARG_SIZE); BUG_ON(_IOC_SIZE(cmd) > NVHOST_AS_IOCTL_MAX_ARG_SIZE);

2
drivers/gpu/nvgpu/gk20a/channel_gk20a.c
View File

@@ -2220,7 +2220,7 @@ long gk20a_channel_ioctl(struct file *filp,
(_IOC_NR(cmd) == 0) || (_IOC_NR(cmd) == 0) ||
(_IOC_NR(cmd) > NVHOST_IOCTL_CHANNEL_LAST) || (_IOC_NR(cmd) > NVHOST_IOCTL_CHANNEL_LAST) ||
(_IOC_SIZE(cmd) > NVHOST_IOCTL_CHANNEL_MAX_ARG_SIZE)) (_IOC_SIZE(cmd) > NVHOST_IOCTL_CHANNEL_MAX_ARG_SIZE))
return -EFAULT; return -EINVAL;
if (_IOC_DIR(cmd) & _IOC_WRITE) { if (_IOC_DIR(cmd) & _IOC_WRITE) {
if (copy_from_user(buf, (void __user *)arg, _IOC_SIZE(cmd))) if (copy_from_user(buf, (void __user *)arg, _IOC_SIZE(cmd)))

2
drivers/gpu/nvgpu/gk20a/ctrl_gk20a.c
View File

@@ -172,7 +172,7 @@ long gk20a_ctrl_dev_ioctl(struct file *filp, unsigned int cmd, unsigned long arg
if ((_IOC_TYPE(cmd) != NVHOST_GPU_IOCTL_MAGIC) || if ((_IOC_TYPE(cmd) != NVHOST_GPU_IOCTL_MAGIC) ||
(_IOC_NR(cmd) == 0) || (_IOC_NR(cmd) == 0) ||
(_IOC_NR(cmd) > NVHOST_GPU_IOCTL_LAST)) (_IOC_NR(cmd) > NVHOST_GPU_IOCTL_LAST))
return -EFAULT; return -EINVAL;
BUG_ON(_IOC_SIZE(cmd) > NVHOST_GPU_IOCTL_MAX_ARG_SIZE); BUG_ON(_IOC_SIZE(cmd) > NVHOST_GPU_IOCTL_MAX_ARG_SIZE);

2
drivers/gpu/nvgpu/gk20a/dbg_gpu_gk20a.c
View File

@@ -372,7 +372,7 @@ long gk20a_dbg_gpu_dev_ioctl(struct file *filp, unsigned int cmd,
if ((_IOC_TYPE(cmd) != NVHOST_DBG_GPU_IOCTL_MAGIC) || if ((_IOC_TYPE(cmd) != NVHOST_DBG_GPU_IOCTL_MAGIC) ||
(_IOC_NR(cmd) == 0) || (_IOC_NR(cmd) == 0) ||
(_IOC_NR(cmd) > NVHOST_DBG_GPU_IOCTL_LAST)) (_IOC_NR(cmd) > NVHOST_DBG_GPU_IOCTL_LAST))
return -EFAULT; return -EINVAL;
BUG_ON(_IOC_SIZE(cmd) > NVHOST_DBG_GPU_IOCTL_MAX_ARG_SIZE); BUG_ON(_IOC_SIZE(cmd) > NVHOST_DBG_GPU_IOCTL_MAX_ARG_SIZE);

2
drivers/gpu/nvgpu/gk20a/tsg_gk20a.c
View File

@@ -213,7 +213,7 @@ long gk20a_tsg_dev_ioctl(struct file *filp, unsigned int cmd,
if ((_IOC_TYPE(cmd) != NVGPU_TSG_IOCTL_MAGIC) || if ((_IOC_TYPE(cmd) != NVGPU_TSG_IOCTL_MAGIC) ||
(_IOC_NR(cmd) == 0) || (_IOC_NR(cmd) == 0) ||
(_IOC_NR(cmd) > NVGPU_TSG_IOCTL_LAST)) (_IOC_NR(cmd) > NVGPU_TSG_IOCTL_LAST))
return -EFAULT; return -EINVAL;
BUG_ON(_IOC_SIZE(cmd) > NVGPU_TSG_IOCTL_MAX_ARG_SIZE); BUG_ON(_IOC_SIZE(cmd) > NVGPU_TSG_IOCTL_MAX_ARG_SIZE);