From 766dfb2cb1412445cb49dfb627fd4d103bf8f372 Mon Sep 17 00:00:00 2001 From: Seema Khowala Date: Thu, 9 May 2019 10:11:17 -0700 Subject: [PATCH] gpu: nvgpu: channel MISRA fix for Rule 17.7 Check return value of below function and add nvgpu_assert. nvgpu_assert is warning on linux but a system halt on safety builds. nvgpu_runlist_reload_ids JIRA NVGPU-3388 Change-Id: Ie2bf6c48d4f9e673695dc6587df24651e9d8c78c Signed-off-by: Seema Khowala Reviewed-on: https://git-master.nvidia.com/r/2115767 Reviewed-by: Thomas Fleury GVS: Gerrit_Virtual_Submit Reviewed-by: Alex Waterman Reviewed-by: mobile promotions Tested-by: mobile promotions --- drivers/gpu/nvgpu/common/fifo/channel.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/nvgpu/common/fifo/channel.c b/drivers/gpu/nvgpu/common/fifo/channel.c index 487620f5f..2884cf1be 100644 --- a/drivers/gpu/nvgpu/common/fifo/channel.c +++ b/drivers/gpu/nvgpu/common/fifo/channel.c @@ -2420,7 +2420,8 @@ int nvgpu_channel_suspend_all_serviceable_ch(struct gk20a *g) } if (channels_in_use) { - nvgpu_runlist_reload_ids(g, active_runlist_ids, false); + nvgpu_assert(nvgpu_runlist_reload_ids(g, + active_runlist_ids, false) == 0); for (chid = 0; chid < f->num_channels; chid++) { struct nvgpu_channel *ch = @@ -2471,7 +2472,8 @@ void nvgpu_channel_resume_all_serviceable_ch(struct gk20a *g) } if (channels_in_use) { - nvgpu_runlist_reload_ids(g, active_runlist_ids, true); + nvgpu_assert(nvgpu_runlist_reload_ids(g, + active_runlist_ids, true) == 0); } nvgpu_log_fn(g, "done");