gpu:nvpgu: avoid checks for MINOR and PATCH version

The NVS protocol is supposed to follow the semantic versioning scheme as
said in the header docs. This means backwards compatibility within the
same major version.
Patch removed the client MINOR and PATCH version comparison with KMD
version.
Patch also returns KMD version irrespective of version compatibility.

Bug 3884011

Change-Id: I756a0f87e911d8549efda8e8f5671f9c6d6a76c9
Signed-off-by: prsethi <prsethi@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvgpu/+/2826431
Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com>
Reviewed-by: svc-mobile-cert <svc-mobile-cert@nvidia.com>
Reviewed-by: Ramesh Mylavarapu <rmylavarapu@nvidia.com>
Reviewed-by: Vaibhav Kachore <vkachore@nvidia.com>
GVS: Gerrit_Virtual_Submit <buildbot_gerritrpt@nvidia.com>
This commit is contained in:
prsethi
2022-12-12 18:53:45 +00:00
committed by mobile promotions
parent 5db14f3bfb
commit 7c7295f2c0
2 changed files with 6 additions and 7 deletions

View File

@@ -680,13 +680,8 @@ static int nvgpu_nvs_ctrl_fifo_scheduler_process_caps_request(struct gk20a *g,
(void)g;
if (request->client_version_major == NVS_DOMAIN_SCHED_VERSION_MAJOR
&& request->client_version_minor == NVS_DOMAIN_SCHED_VERSION_MINOR
&& request->client_version_patch == NVS_DOMAIN_SCHED_VERSION_PATCH) {
if (request->client_version_major == NVS_DOMAIN_SCHED_VERSION_MAJOR) {
result = 0;
response->sched_version_major = NVS_DOMAIN_SCHED_VERSION_MAJOR;
response->sched_version_minor = NVS_DOMAIN_SCHED_VERSION_MINOR;
response->sched_version_patch = NVS_DOMAIN_SCHED_VERSION_PATCH;
response->client_version_status = NVS_DOMAIN_MSG_CTRL_GET_CAPS_RESP_CLIENT_VERSION_STATUS_OK;
} else {
result = 1;
@@ -694,6 +689,10 @@ static int nvgpu_nvs_ctrl_fifo_scheduler_process_caps_request(struct gk20a *g,
NVS_DOMAIN_MSG_CTRL_GET_CAPS_RESP_CLIENT_VERSION_STATUS_FAILED;
}
response->sched_version_major = NVS_DOMAIN_SCHED_VERSION_MAJOR;
response->sched_version_minor = NVS_DOMAIN_SCHED_VERSION_MINOR;
response->sched_version_patch = NVS_DOMAIN_SCHED_VERSION_PATCH;
return result;
}

View File

@@ -189,7 +189,7 @@ static int test_nvs_worker(struct unit_module *m,
client_request_caps->client_version_minor = NVS_DOMAIN_SCHED_VERSION_MINOR;
client_request_caps->client_version_patch = NVS_DOMAIN_SCHED_VERSION_PATCH;
if (error_case) {
client_request_caps->client_version_patch = 127U;
client_request_caps->client_version_major = 127U;
}
} else if (message_type == 1) {
fifo_msg_type = NVS_DOMAIN_MSG_TYPE_CTRL_SWITCH_DOMAIN;