From 7d50efb6bcd9c7980d15880b88b126b85f79d78f Mon Sep 17 00:00:00 2001 From: Jinesh Parakh Date: Fri, 6 May 2022 10:47:24 +0530 Subject: [PATCH] gpu: nvgpu: Uninitialized pointer read Fix the following Coverity Defect: vm_remap.c : Uninitialized pointer read CID 10127932 Bug 3460991 Signed-off-by: Jinesh Parakh Change-Id: I2de290882aec6a859c5280998e11fb75f3395302 Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvgpu/+/2708539 Reviewed-by: Sachin Nikam Reviewed-by: svc-mobile-coverity Reviewed-by: svc-mobile-cert GVS: Gerrit_Virtual_Submit --- drivers/gpu/nvgpu/os/linux/vm_remap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/nvgpu/os/linux/vm_remap.c b/drivers/gpu/nvgpu/os/linux/vm_remap.c index f34460bc3..6dc32a30a 100644 --- a/drivers/gpu/nvgpu/os/linux/vm_remap.c +++ b/drivers/gpu/nvgpu/os/linux/vm_remap.c @@ -43,7 +43,7 @@ int nvgpu_vm_remap_os_buf_get(struct vm_gk20a *vm, struct dma_buf *dmabuf; struct sg_table *sgt = NULL; struct nvgpu_sgt *nv_sgt = NULL; - struct dma_buf_attachment *attachment; + struct dma_buf_attachment *attachment = NULL; enum nvgpu_aperture aperture; enum dma_data_direction dmabuf_direction; int err = 0; @@ -105,7 +105,7 @@ int nvgpu_vm_remap_os_buf_get(struct vm_gk20a *vm, return 0; clean_up: - if (IS_ERR(sgt)) { + if (!IS_ERR(sgt)) { nvgpu_mm_unpin(dev, dmabuf, attachment, sgt); } dma_buf_put(dmabuf);