From 7f87599df98df55a1f1df0d2a6c176bf492e0742 Mon Sep 17 00:00:00 2001 From: Philip Elcan Date: Mon, 23 Sep 2019 16:13:41 -0400 Subject: [PATCH] gpu: nvgpu: whitelist MISRA violations due to true/false bug Whitelist false positive violations cause by a Coverity bug that misinterprets "true" and "false" as integers. See nvbug 2623654 for details on the bug. JIRA NVGPU-4031 Change-Id: Id144eac1d23be5cfaba73322c3e89c76b5664d6c Signed-off-by: Philip Elcan Reviewed-on: https://git-master.nvidia.com/r/2203976 Reviewed-by: mobile promotions Tested-by: mobile promotions --- drivers/gpu/nvgpu/common/mm/gmmu/page_table.c | 2 ++ drivers/gpu/nvgpu/include/nvgpu/gmmu.h | 1 + drivers/gpu/nvgpu/include/nvgpu/posix/cond.h | 2 ++ 3 files changed, 5 insertions(+) diff --git a/drivers/gpu/nvgpu/common/mm/gmmu/page_table.c b/drivers/gpu/nvgpu/common/mm/gmmu/page_table.c index ba9fd7353..3de5fa057 100644 --- a/drivers/gpu/nvgpu/common/mm/gmmu/page_table.c +++ b/drivers/gpu/nvgpu/common/mm/gmmu/page_table.c @@ -45,6 +45,7 @@ } else { \ nvgpu_log(g, gpu_dbg_map, fmt, ##args); \ } \ +NVGPU_COV_WHITELIST(false_positive, NVGPU_MISRA(Rule, 14_4), "Bug 2623654") \ } while (false) #define nvgpu_gmmu_dbg_v(g, attrs, fmt, args...) \ @@ -54,6 +55,7 @@ } else { \ nvgpu_log(g, gpu_dbg_map_v, fmt, ##args); \ } \ +NVGPU_COV_WHITELIST(false_positive, NVGPU_MISRA(Rule, 14_4), "Bug 2623654") \ } while (false) static int pd_allocate(struct vm_gk20a *vm, diff --git a/drivers/gpu/nvgpu/include/nvgpu/gmmu.h b/drivers/gpu/nvgpu/include/nvgpu/gmmu.h index 5341e001f..cc4a6c032 100644 --- a/drivers/gpu/nvgpu/include/nvgpu/gmmu.h +++ b/drivers/gpu/nvgpu/include/nvgpu/gmmu.h @@ -260,6 +260,7 @@ void nvgpu_gmmu_unmap_locked(struct vm_gk20a *vm, } else { \ nvgpu_log(g, gpu_dbg_pte, fmt, ##args); \ } \ +NVGPU_COV_WHITELIST(false_positive, NVGPU_MISRA(Rule, 14_4), "Bug 2623654") \ } while (false) #endif /* NVGPU_GMMU_H */ diff --git a/drivers/gpu/nvgpu/include/nvgpu/posix/cond.h b/drivers/gpu/nvgpu/include/nvgpu/posix/cond.h index 1b8f164e1..c3529b9ad 100644 --- a/drivers/gpu/nvgpu/include/nvgpu/posix/cond.h +++ b/drivers/gpu/nvgpu/include/nvgpu/posix/cond.h @@ -23,6 +23,7 @@ #ifndef NVGPU_POSIX_COND_H #define NVGPU_POSIX_COND_H +#include #include #include @@ -115,6 +116,7 @@ do { \ ret = nvgpu_cond_timedwait(cond, \ &cond_wait_timeout_timeout); \ } \ +NVGPU_COV_WHITELIST(false_positive, NVGPU_MISRA(Rule, 14_4), "Bug 2623654") \ } while (false) #endif /* NVGPU_POSIX_COND_H */