nv-tegra-mirror/linux-nvgpu
1
0
Fork 0
mirror of git://nv-tegra.nvidia.com/linux-nvgpu.git synced 2025-12-22 17:36:20 +03:00
Code Issues Packages Projects Releases Wiki Activity

nvgpu: sysfs: remove 'allow_all' from prod build

Browse Source 
REG_OPS whitelist can be bypassed using sysfs
/sys/devices/gpu.0/allow_all
Sysfs are privileged, need Root access to set this sysfs.
This node should not be exposed by NVGPU-RM in Linux prod builds.

Bug 4083557

Change-Id: I984212df7a9f2dfeb6759cc502ae485daa1d82d4
Signed-off-by: Deepak Goyal <dgoyal@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvgpu/+/2893829
Reviewed-by: Sagar Kamble <skamble@nvidia.com>
Reviewed-by: Vaibhav Kachore <vkachore@nvidia.com>
GVS: Gerrit_Virtual_Submit <buildbot_gerritrpt@nvidia.com>
This commit is contained in:
Deepak Goyal
2023-04-25 10:51:46 +00:00
committed by mobile promotions
parent 01d3ed09b0
commit 811f8546cf
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/gpu/nvgpu/os/linux/sysfs.c
View File

@@ -1516,8 +1516,12 @@ void nvgpu_remove_sysfs(struct device *dev)
device_remove_file(dev, &dev_attr_force_idle); device_remove_file(dev, &dev_attr_force_idle);
device_remove_file(dev, &dev_attr_railgate_enable); device_remove_file(dev, &dev_attr_railgate_enable);
#endif #endif
device_remove_file(dev, &dev_attr_allow_all);
device_remove_file(dev, &dev_attr_golden_img_status); device_remove_file(dev, &dev_attr_golden_img_status);
#ifdef CONFIG_NVGPU_DEBUGGER
if (g->support_gpu_tools) {
device_remove_file(dev, &dev_attr_allow_all);
}
#endif
device_remove_file(dev, &dev_attr_tpc_fs_mask); device_remove_file(dev, &dev_attr_tpc_fs_mask);
device_remove_file(dev, &dev_attr_tpc_pg_mask); device_remove_file(dev, &dev_attr_tpc_pg_mask);
device_remove_file(dev, &dev_attr_gpc_fs_mask); device_remove_file(dev, &dev_attr_gpc_fs_mask);
@@ -1593,8 +1597,12 @@ int nvgpu_create_sysfs(struct device *dev)
error |= device_create_file(dev, &dev_attr_force_idle); error |= device_create_file(dev, &dev_attr_force_idle);
error |= device_create_file(dev, &dev_attr_railgate_enable); error |= device_create_file(dev, &dev_attr_railgate_enable);
#endif #endif
error |= device_create_file(dev, &dev_attr_allow_all);
error |= device_create_file(dev, &dev_attr_golden_img_status); error |= device_create_file(dev, &dev_attr_golden_img_status);
#ifdef CONFIG_NVGPU_DEBUGGER
if (g->support_gpu_tools) {
error |= device_create_file(dev, &dev_attr_allow_all);
}
#endif
error |= device_create_file(dev, &dev_attr_tpc_fs_mask); error |= device_create_file(dev, &dev_attr_tpc_fs_mask);
error |= device_create_file(dev, &dev_attr_tpc_pg_mask); error |= device_create_file(dev, &dev_attr_tpc_pg_mask);
error |= device_create_file(dev, &dev_attr_gpc_fs_mask); error |= device_create_file(dev, &dev_attr_gpc_fs_mask);