From 89155d0ed1bcfa8bafb80ff3e5965ce0109c4629 Mon Sep 17 00:00:00 2001 From: Thomas Fleury Date: Fri, 10 May 2019 10:44:52 -0700 Subject: [PATCH] gpu: nvgpu: fix MISRA 21.2 violation in rbtree Below MISRA 21.2 violation is reported in nvgpu.common.rbtree ${TEGRA_TOP}/kernel/nvgpu/drivers/gpu/nvgpu/common/rbtree.c:188: misra_violation: _delete_fixup shall not be declared. Fix this by renaming to delete_fixup. Jira NVGPU-3305 Change-Id: I09d8da721cc87d3bb9e4a23d00a31a82a8759365 Signed-off-by: Thomas Fleury Reviewed-on: https://git-master.nvidia.com/r/2116681 GVS: Gerrit_Virtual_Submit Reviewed-by: Nicolas Benech Reviewed-by: Vinod Gopalakrishnakurup Reviewed-by: mobile promotions Tested-by: mobile promotions --- drivers/gpu/nvgpu/common/rbtree.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/nvgpu/common/rbtree.c b/drivers/gpu/nvgpu/common/rbtree.c index 6bf4c19d9..2d6843acf 100644 --- a/drivers/gpu/nvgpu/common/rbtree.c +++ b/drivers/gpu/nvgpu/common/rbtree.c @@ -185,7 +185,7 @@ void nvgpu_rbtree_insert(struct nvgpu_rbtree_node *new_node, /* * maintain red-black tree balance after deleting node x */ -static void _delete_fixup(struct nvgpu_rbtree_node **root, +static void delete_fixup(struct nvgpu_rbtree_node **root, struct nvgpu_rbtree_node *parent_of_x, struct nvgpu_rbtree_node *x) { @@ -350,7 +350,7 @@ void nvgpu_rbtree_unlink(struct nvgpu_rbtree_node *node, } if (y_was_black) { - _delete_fixup(root, parent_of_x, x); + delete_fixup(root, parent_of_x, x); } }